fix discover input background not shrink #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ruanyl
added
backport 2.x
discover
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8331 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88843 88849 +6
Branches 13855 13856 +1
=======================================
+ Hits 56987 56994 +7
+ Misses 31241 31240 -1
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-changeset-bot bot
added a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Sep 26, 2024
SuZhou-Joe
reviewed
Sep 26, 2024
SuZhou-Joe
previously approved these changes
Sep 26, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
fix-discover-input-not-shrink
branch
from
3675796
to
a7fc623
Compare
abbyhu2000
approved these changes
Sep 26, 2024
ashwin-pc
approved these changes
Sep 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
* fix discover input background not shrink Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #8331 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ea8b716) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 27, 2024
* fix discover input background not shrink * Changeset file for PR #8331 created/updated --------- (cherry picked from commit ea8b716) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ps48
pushed a commit
to ps48/OpenSearch-Dashboards
that referenced
this pull request
Sep 27, 2024
* fix discover input background not shrink Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR opensearch-project#8331 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one line change fixed an issue of the query input on discover page that the input background container didn't not shrink when resizing, see the screen records:
Before:
Screen.Recording.2024-09-25.at.17.46.31.mov
After:
Screen.Recording.2024-09-25.at.17.45.24.mov
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration