Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page Header]Fix responsiveness issue for dashboards & visualization app headers #8329

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Sep 25, 2024

Description

  • [Page Header]Fix responsiveness issue for dashboards & visualization app header
iShot_2024-09-25_16.00.14.mp4

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@zhongnansu zhongnansu marked this pull request as ready for review September 25, 2024 08:13
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Sep 25, 2024
@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (8d45530) to head (a502ab4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8329   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88841    88841           
  Branches    13855    13855           
=======================================
  Hits        56985    56985           
  Misses      31241    31241           
  Partials      615      615           
Flag Coverage Δ
Linux_1 30.06% <ø> (ø)
Linux_2 58.86% <ø> (ø)
Linux_3 40.35% <ø> (?)
Linux_4 31.58% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.81% <ø> (ø)
Windows_3 40.35% <ø> (ø)
Windows_4 31.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virajsanghvi
virajsanghvi previously approved these changes Sep 25, 2024
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming comment isn't an issue and ci passes

@virajsanghvi
Copy link
Collaborator

virajsanghvi commented Sep 25, 2024

Can you check why
image
gets misaligned on small screens per your video?

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Sep 25, 2024
@zhongnansu
Copy link
Member Author

Can you check why image gets misaligned on small screens per your video?

@virajsanghvi fixed the css issue and updated the PR

virajsanghvi
virajsanghvi previously approved these changes Sep 25, 2024
@virajsanghvi
Copy link
Collaborator

note: May want to rerun ci for failed tasks

…aders

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@zhongnansu
Copy link
Member Author

note: May want to rerun ci for failed tasks

@virajsanghvi Fixed. The stying issue of scss file. Do you have any recommendation for a good scss formatting tool? I remember researching for some, but not very good to use

@zhongnansu zhongnansu merged commit 8db6a16 into opensearch-project:main Sep 26, 2024
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8329-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8db6a165f55aeded58e0220680dde3030b1097d1
# Push it to GitHub
git push --set-upstream origin backport/backport-8329-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8329-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8329-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8db6a165f55aeded58e0220680dde3030b1097d1
# Push it to GitHub
git push --set-upstream origin backport/backport-8329-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8329-to-2.17.

zhongnansu added a commit to zhongnansu/OpenSearch-Dashboards that referenced this pull request Sep 26, 2024
…aders (opensearch-project#8329)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 8db6a16)
zhongnansu added a commit that referenced this pull request Sep 26, 2024
…aders (#8329) (#8359)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 8db6a16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.17 distinguished-contributor look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants