-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page Header]Fix responsiveness issue for dashboards & visualization app headers #8329
[Page Header]Fix responsiveness issue for dashboards & visualization app headers #8329
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8329 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 3743 3743
Lines 88841 88841
Branches 13855 13855
=======================================
Hits 56985 56985
Misses 31241 31241
Partials 615 615
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving assuming comment isn't an issue and ci passes
src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx
Outdated
Show resolved
Hide resolved
ed211d4
to
27d27ed
Compare
27d27ed
to
da6fd02
Compare
da6fd02
to
8757e15
Compare
@virajsanghvi fixed the css issue and updated the PR |
note: May want to rerun ci for failed tasks |
…aders Signed-off-by: Zhongnan Su <szhongna@amazon.com>
8757e15
to
a502ab4
Compare
@virajsanghvi Fixed. The stying issue of scss file. Do you have any recommendation for a good scss formatting tool? I remember researching for some, but not very good to use |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8329-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8db6a165f55aeded58e0220680dde3030b1097d1
# Push it to GitHub
git push --set-upstream origin backport/backport-8329-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8329-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8db6a165f55aeded58e0220680dde3030b1097d1
# Push it to GitHub
git push --set-upstream origin backport/backport-8329-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
…aders (opensearch-project#8329) Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit 8db6a16)
Description
iShot_2024-09-25_16.00.14.mp4
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration