Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace][Bug]Fix workspace detail page issues #8317

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 24, 2024

Description

Fix workspace detail page issues:

  • Add a modal warning if user navigates away without saving changes in any of the tabs
  • Add “Set as default" button
  • Add a mock for the header when the workspace is set to default
  • Right align the column with Related connections number
  • Delete workspace overview link from detail panel
  • Add view workspace button

Issues Resolved

Screenshot

Add a modal warning if user navigates away without saving changes in any of the tabs
Add “Set as default" button and Add a mock for the header when the workspace is set to default

2024-09-25.11.38.36.mp4

Right align the column with Related connections number:
image

Delete workspace overview link from detail panel and Add view workspace button
image

Testing the changes

Changelog

  • fix: Fix workspace detail page issues

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
…enSearch-Dashboards into 2.17/update-workspace-detail
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.91%. Comparing base (59200d0) to head (7cb95e3).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/workspace_detail/workspace_detail.tsx 45.00% 10 Missing and 1 partial ⚠️
...rc/core/public/application/application_service.tsx 0.00% 2 Missing ⚠️
...ents/workspace_detail/select_data_source_panel.tsx 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8317      +/-   ##
==========================================
- Coverage   64.14%   60.91%   -3.23%     
==========================================
  Files        3743     3749       +6     
  Lines       88833    89029     +196     
  Branches    13852    13902      +50     
==========================================
- Hits        56979    54232    -2747     
- Misses      31239    31433     +194     
- Partials      615     3364    +2749     
Flag Coverage Δ
Linux_1 28.84% <38.46%> (-1.23%) ⬇️
Linux_2 56.34% <33.33%> (-2.52%) ⬇️
Linux_3 ?
Linux_4 29.94% <0.00%> (-1.65%) ⬇️
Windows_1 28.86% <38.46%> (-1.23%) ⬇️
Windows_2 56.30% <33.33%> (-2.52%) ⬇️
Windows_3 37.75% <0.00%> (-2.61%) ⬇️
Windows_4 29.94% <0.00%> (-1.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants