-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Worksapce] Hide delete button for non osd admins in workspace list #8315
base: main
Are you sure you want to change the base?
[Worksapce] Hide delete button for non osd admins in workspace list #8315
Conversation
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
isDashboardAdmin && ( | ||
<> | ||
<EuiButton color="danger" iconType="trash" onClick={onClick}> | ||
Delete {selection.length} Workspace | ||
</EuiButton> | ||
{deletedWorkspaces && deletedWorkspaces.length > 0 && ( | ||
<DeleteWorkspaceModal | ||
selectedWorkspaces={deletedWorkspaces} | ||
onClose={() => setDeletedWorkspaces([])} | ||
/> | ||
)} | ||
</> | ||
) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we hide the checkbox as well? the only action user can take for multiple select is batch delete, if we hide the delete button and keep multi select, that looks a little wired user can't do anything after select.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Description
Hide delete button for non osd admins in workspace list
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration