Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] fix breadcrumbs for workspace #8303

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Workspace] fix breadcrumbs for workspace #8303

wants to merge 10 commits into from
+170 −491

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented Sep 23, 2024 •
edited
Loading

Description

  • prepend workspace name and icon into breadcrumbs
  • remove Home from breadcrumbs
  • workspace overview page title change to Overview
  • Workspace settings page breadcrumbs update

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: [Workspace] prepend workspace name and icon to breadcrumbs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Hailong-am
update breadcrumbs
180eae2 
Signed-off-by: Hailong Cui <ihailong@amazon.com>
opensearch-changeset-bot bot added a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 23, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8303 created/updated
e7053da
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.91%. Comparing base (8691010) to head (e723d52).

Files with missing lines Patch % Lines
src/plugins/workspace/public/utils.ts 71.42% 1 Missing and 1 partial ⚠️
...onents/workspace_name/workspace_name_with_icon.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8303      +/-   ##
==========================================
- Coverage   60.92%   60.91%   -0.01%     
==========================================
  Files        3749     3750       +1     
  Lines       89021    89009      -12     
  Branches    13899    13893       -6     
==========================================
- Hits        54236    54224      -12     
+ Misses      31423    31420       -3     
- Partials     3362     3365       +3
Flag Coverage Δ
Linux_1 28.84% <64.28%> (-0.01%) ⬇️
Linux_2 56.34% <100.00%> (-0.01%) ⬇️
Linux_3 37.76% <0.00%> (?)
Linux_4 29.94% <71.42%> (+<0.01%) ⬆️
Windows_1 28.86% <64.28%> (-0.01%) ⬇️
Windows_2 56.30% <100.00%> (-0.01%) ⬇️
Windows_3 37.76% <0.00%> (-0.01%) ⬇️
Windows_4 29.94% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-changeset-bot @Hailong-am
Changeset file for PR opensearch-project#8303 created/updated
194c213 
fix bootstrap error

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am
make the workspace name not repsonsive that will not break into two rows
b1db16f 
Signed-off-by: Hailong Cui <ihailong@amazon.com>

fix bootstrap error

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am changed the title [Workspace] prepend workspace name to breadcrumbs [Workspace] fix breadcrumbs for workspace Sep 24, 2024
@Hailong-am
fix failed unit test
642c9bc 
Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am marked this pull request as ready for review September 24, 2024 04:03
@Hailong-am
Copy link
Contributor Author

link checker failure will handled by #8309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
all-star-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hailong-am