Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Disable "Save changes" button on character limit exceeded #8153

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 12, 2024

Description

This PR is for disable the 'Save Changes' button when the number of characters in the name or description exceeds the maximum limit.

Issues Resolved

#8154

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version ignore
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Visiting a existing workspace settings page
  • Click "Edit" button
  • Input a long workspace name or description, the "Save changes" button should be disabled.

Changelog

  • fix: [Workspace]Disable "Save changes" button on character limit exceeded

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (8db6a16) to head (f6b31eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8153   +/-   ##
=======================================
  Coverage   64.14%   64.14%           
=======================================
  Files        3743     3743           
  Lines       88841    88851   +10     
  Branches    13855    13858    +3     
=======================================
+ Hits        56985    56996   +11     
+ Misses      31241    31240    -1     
  Partials      615      615           
Flag Coverage Δ
Linux_1 30.06% <100.00%> (+<0.01%) ⬆️
Linux_2 58.86% <ø> (ø)
Linux_3 40.36% <ø> (+0.01%) ⬆️
Linux_4 31.58% <ø> (-0.01%) ⬇️
Windows_1 30.08% <100.00%> (+<0.01%) ⬆️
Windows_2 58.81% <ø> (ø)
Windows_3 40.36% <ø> (+<0.01%) ⬆️
Windows_4 31.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants