[Manual Backport 2.x] [Workspace] Add user settings #8057

Hailong-am · 2024-09-06T15:02:15Z

backport 569b70d from #7953

(cherry picked from commit 569b70d) Signed-off-by: Hailong Cui <ihailong@amazon.com>

github-actions · 2024-09-06T15:02:48Z

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

codecov · 2024-09-06T15:17:44Z

Codecov Report

Attention: Patch coverage is 66.94561% with 79 lines in your changes missing coverage. Please review.

Project coverage is 60.67%. Comparing base (cc5f3cb) to head (9bf568d).
Report is 1 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
src/plugins/workspace/server/utils.ts	5.55%	17 Missing ⚠️
src/core/server/ui_settings/ui_settings_client.ts	77.08%	4 Missing and 7 partials ⚠️
...rkspace/public/components/workspace_list/index.tsx	80.00%	7 Missing and 3 partials ⚠️
src/plugins/advanced_settings/public/plugin.ts	43.75%	8 Missing and 1 partial ⚠️
...d_settings/public/management_app/user_settings.tsx	64.28%	4 Missing and 1 partial ⚠️
src/plugins/workspace/server/routes/index.ts	0.00%	5 Missing ⚠️
...ntent_management/public/components/page_render.tsx	55.55%	2 Missing and 2 partials ⚠️
src/plugins/workspace/public/plugin.ts	50.00%	3 Missing and 1 partial ⚠️
...r/saved_objects/user_ui_settings_client_wrapper.ts	91.42%	1 Missing and 2 partials ⚠️
...ade_saved_config/create_or_upgrade_saved_config.ts	66.66%	1 Missing and 1 partial ⚠️
... and 6 more

Additional details and impacted files

@@           Coverage Diff            @@
##              2.x    #8057    +/-   ##
========================================
  Coverage   60.67%   60.67%            
========================================
  Files        3731     3737     +6     
  Lines       88452    88653   +201     
  Branches    13709    13770    +61     
========================================
+ Hits        53664    53790   +126     
- Misses      31526    31584    +58     
- Partials     3262     3279    +17

Flag	Coverage Δ
Linux_1	`28.77% <34.73%> (+<0.01%)`	⬆️
Linux_2	`56.38% <70.14%> (+<0.01%)`	⬆️
Linux_3	`37.54% <42.95%> (+0.06%)`	⬆️
Linux_4	`29.73% <8.41%> (-0.04%)`	⬇️
Windows_1	`28.78% <34.73%> (+<0.01%)`	⬆️
Windows_2	`56.33% <70.14%> (+<0.01%)`	⬆️
Windows_3	`37.54% <42.95%> (+0.06%)`	⬆️
Windows_4	`29.73% <8.41%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hailong-am · 2024-09-06T16:01:03Z

cypress failure is not related to this change.

src/core/server/ui_settings/ui_settings_client.ts

AMoo-Miki · 2024-09-06T16:32:19Z

src/core/server/ui_settings/utils.ts

+
+export const CURRENT_USER_PLACEHOLDER = '<current_user>';
+
+export const generateDocId = (id: string, scope?: UiSettingScope) => {


This function name is not inline with what it is actually doing.

updated to buildDocIdWithScope

src/plugins/advanced_settings/server/saved_objects/user_ui_settings_client_wrapper.ts

src/plugins/workspace/public/components/workspace_list/index.tsx

AMoo-Miki · 2024-09-06T16:46:38Z

We should also mark this experimental in the config and changelog to allow for making changes to the API and functionality without causing a breaking change.

Hailong-am · 2024-09-07T01:18:46Z

We should also mark this experimental in the config and changelog to allow for making changes to the API and functionality without causing a breaking change.

@AMoo-Miki thanks, it should be experimental. As this is backport PR I will have the quick follow up PR to address all your comments. have an issue to track #8072.

Signed-off-by: Hailong Cui <ihailong@amazon.com>

Hailong-am · 2024-09-07T04:27:39Z

@AMoo-Miki @SuZhou-Joe @ruanyl comments are addressed, please add backport 2.17 label for this PR and close #8058 this one.

For main, i will have another PR to cherry pick the commit that will not need to backport.

AMoo-Miki

Thanks.

* [Workspace] Add User level setting (#7953) (cherry picked from commit 569b70d) Signed-off-by: Hailong Cui <ihailong@amazon.com> * add experimental to user personal settings and support i18n Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit eccf54f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [Workspace] Add User level setting (#7953) (cherry picked from commit 569b70d) * add experimental to user personal settings and support i18n --------- (cherry picked from commit eccf54f) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[Workspace] Add User level setting (opensearch-project#7953)

95f4594

(cherry picked from commit 569b70d) Signed-off-by: Hailong Cui <ihailong@amazon.com>

github-actions bot added the failed changeset label Sep 6, 2024

Hailong-am force-pushed the backport/backport-7953-to-2.x branch from 78034d1 to 95f4594 Compare September 6, 2024 15:02