Skip to content

Commit

Permalink
Refactor hardcode color to use OUI in maps_legacy (#4294)
Browse files Browse the repository at this point in the history
* Refactor color to use OUI
* Pull theme value from actual active theme
* Update changelog

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
  • Loading branch information
3 people committed Jun 26, 2023
1 parent fe1f1d1 commit 0b54e84
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Remove unused Sass in `tile_map` plugin ([#4110](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4110))
- [Table Visualization] Remove custom styling for text-align:center in favor of OUI utility class. ([#4164](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4164))
- Replace the use of `bluebird` in `saved_objects` plugin ([#4026](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4026))
- [Vis Colors] Update default color in TSVB to use `ouiPaletteColorBlind()[0]`([#4363](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4363))
- [Vis Colors] Replace vis_type_timeline colors with `ouiPaletteColorBlind()` ([#4366](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4366))
- [Vis Colors] [Maps] Replace hardcoded color to OUI color in `maps_legacy` plugin ([#4294](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4294))
- [Vis Colors] [TSVB] Update default color in `vis_type_timeseries` to use `ouiPaletteColorBlind()[0]`([#4363](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4363))
- [Vis Colors] [Timeline] Replace `vis_type_timeline` colors with `ouiPaletteColorBlind()` ([#4366](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4366))

### 🔩 Tests

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { i18n } from '@osd/i18n';
import { ORIGIN } from '../common/constants/origin';
import { getToasts } from '../opensearch_dashboards_services';
import { L } from '../leaflet';
import { euiThemeVars } from '@osd/ui-shared-deps/theme';

function makeFitControl(fitContainer, opensearchDashboardsMap) {
// eslint-disable-next-line no-undef
Expand Down Expand Up @@ -474,7 +475,7 @@ export class OpenSearchDashboardsMap extends EventEmitter {
}

addDrawControl() {
const drawColor = '#000';
const drawColor = euiThemeVars.euiColorInk;
const drawOptions = {
draw: {
polyline: false,
Expand Down

0 comments on commit 0b54e84

Please sign in to comment.