Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] 'Back to products list' Button on Edit Product removed filters on Products page #12698

Closed
chahmedejaz opened this issue Jul 23, 2024 · 1 comment · Fixed by #12735
Closed
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.

Comments

@chahmedejaz
Copy link
Collaborator

chahmedejaz commented Jul 23, 2024

Description

Ref: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1720708764308569
After successfully editing the product, the user clicks on the 'Back to products list' button, then the previously selected filters are removed and all the products are displayed.

This is a regression of feature added in #4206

Expected Behavior

Previously selected filters should persist.

Actual Behaviour

Previously selected filters are removed.

Steps to Reproduce

  1. Filter the products page such that not all the products are being displayed
  2. Edit any of the filtered products, any field in any of the below sections:
    image
  3. Once finished, Click on "Back to products lists" button
  4. It redirects to page with no filters applied

Workaround

User can reselect all the filters which was selected before navigation back from the product edit page.

Severity

bug-s3: a feature is broken but there is a workaround

Your Environment

  • Version used: Latest master
  • Browser name and version: Chrome
  • Operating System and version (desktop or mobile): Windows plus WSL

Depends On

Possible Fix

We can use server session storage to store the URL with the applied filters and upon navigation back, we use that stored URL.

@chahmedejaz chahmedejaz added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Jul 23, 2024
@chahmedejaz chahmedejaz self-assigned this Jul 23, 2024
@chahmedejaz chahmedejaz changed the title 'Back to products list' Button on Edit Product removed filters on Products page [BUU] - 'Back to products list' Button on Edit Product removed filters on Products page Jul 23, 2024
@chahmedejaz
Copy link
Collaborator Author

chahmedejaz commented Jul 26, 2024

As the URL state management is fixed and merged, I'm starting the work for this issue.

@sigmundpetersen sigmundpetersen changed the title [BUU] - 'Back to products list' Button on Edit Product removed filters on Products page [BUU] 'Back to products list' Button on Edit Product removed filters on Products page Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant