-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style rule of error message when enterprise does not have shipping or payment method activated #12362
Comments
It seems the error message is on top of the screen. Well stylized and permits interaction with the bottom panel. |
@MrBowmanXD sorry I forgot an important information when writting the issue: you need to turn feature toggle "admin_style_v3" ON to see the problem. You can fin toggles as superadmin on |
will try to replicate. |
@tschumilas or @dacook can you still replicate? I can't on my end, but I never could, the screenshot in the issue is actually yours David :) maybe the issue is missing an important step. |
Hi @MrBowmanXD , thanks for looking into this. I'm sorry, the issue was out of date. I've updated it now to show that there were two problems. The one you checked is solved already, but the remaining issue is at the:
|
Can you replicate in a video or image please? Did not understand the text: | bottom of the new bulk edit products screen, preventing interaction (/admin/products with admin_style_v3 feature toggle) |
Wait, so should div called flash container be behind the content in order to let user click on things? (possibly by lowering z-index) I have to check this out in the code editor. |
It sounds like you're on the right track, yes. I've added a Loom video to the description of this issue, I hope that helps. |
Thanks for the video, will get on this issue soon. |
Hi @MrBowmanXD , just wondering if you'll be able to look into this soon? |
Hello, sorry been ocupied with stuff related to my internship. I might look in the weekend, because i will start the internship tuesday. |
I found a fix for this. Will submit a PR. |
Description
When an enterprise has no shipping or payment methods activated, an error message is displayed on all pages. It is overlapping with the
bottom saving banner, preventing the user to fix the error message easily. (e.g. at/admin/enterprises/*/edit
)/admin/products
withadmin_style_v3
feature toggle)The goal here is to fix the style rule so that you can at least click in the space underneath the error message
Steps to Reproduce
Animated Gif/Screenshot
In bulk edit products, you cannot click anywhere in the purple area:
Loom video: https://www.loom.com/share/2fb04215bdcb424f923a52606ef7c088?sid=0d6e542f-08eb-4d50-ae11-ad755c208615
Severity
bug-s3: a feature is broken but there is a workaround
Your Environment
The text was updated successfully, but these errors were encountered: