Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Specs for bulk products feature parity #11845

Closed
dacook opened this issue Nov 22, 2023 · 6 comments
Closed

[BUU] Specs for bulk products feature parity #11845

dacook opened this issue Nov 22, 2023 · 6 comments
Assignees

Comments

@dacook
Copy link
Member

dacook commented Nov 22, 2023

We have tests on the old bulk edit products screen, which we should make sure is covered by the new bulk edit products spec

This would be necessary before removing the admin_style_v3 feature toggle.

As an Administrator
  I want to be able to manage products in bulk
  listing products
    displays a list of products
    displays a message when number of products is zero
    displays a select box for suppliers, with the appropriate supplier selected
    displays an on hand count in a span for each product
    displays 'on demand' for any variant that is available on demand
    displays a select box for the unit of measure for the product's variants
    displays a text field for the item name when unit is set to 'Items'
@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Nov 28, 2023

I think there are some test cases here which are blocked by #11060, because they concern some functionalities which were not yet implemented. Specifically, I mean changing:

  • producer
  • unit type
  • product category
  • tax category

I've updated the tests which I think do not relate to these changes (although they might break once the page is changed again).

I think it's generally a good idea to have the branch green, so I'll signal these pending test cases, and mark this issue as blocked.

@dacook
Copy link
Member Author

dacook commented May 20, 2024

I believe this is now unblocked, because all the items listed above are now implemented.
Hopefully, most of the checks in bulk_product_update_spec.rb are already covered in products_v3/products_spec.rb, but it will be worth reviewing to make sure. If there are any gaps, we can add them to the new spec file.

Then when we disable the old products screen, we can remove the old spec file at the same time.

@dacook dacook removed the blocked label May 20, 2024
@filipefurtad0
Copy link
Contributor

Thanks for signalling @dacook 🙌

@mkllnk
Copy link
Member

mkllnk commented Jun 6, 2024

@filipefurtad0, when do you think this issue will be done?

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Jun 6, 2024

Hi @mkllnk ,
Depending on what's missing, I think we should be done during next week (worst case scenario), but I think earlier.

@dacook
Copy link
Member Author

dacook commented Jun 18, 2024

🎉

@dacook dacook closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants