Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trix editor to Product Description Editor #11129

Closed
lin-d-hop opened this issue Jun 27, 2023 · 6 comments · Fixed by #11140
Closed

Add Trix editor to Product Description Editor #11129

lin-d-hop opened this issue Jun 27, 2023 · 6 comments · Fixed by #11140
Assignees
Labels
papercut Labels papercuts after they've moved from the "Papercuts prioritized" column US Selected to be done by the US active instance

Comments

@lin-d-hop
Copy link
Contributor

lin-d-hop commented Jun 27, 2023

Description

Replace the existing angular WYSIWYG editor with the Trix editor.
Here https://openfoodnetwork.org.uk/admin/products/new
And here https://openfoodnetwork.org.uk/admin/products/[_product-name_]/edit

Acceptance Criteria & Tests

  1. Remove old angular WYSIWYG
  2. Replace with the Trix editor for product description
  3. Test <hr> and <br>. Plus bullet points, strikethrough, headings etc etc.

From: openfoodfoundation/wishlist#427

@lin-d-hop lin-d-hop added US Selected to be done by the US active instance papercut Labels papercuts after they've moved from the "Papercuts prioritized" column labels Jun 27, 2023
@jibees jibees self-assigned this Jun 27, 2023
@RachL
Copy link
Contributor

RachL commented Jul 5, 2023

@lin-d-hop @jibees does this close openfoodfoundation/wishlist#63 ?

@jibees
Copy link
Contributor

jibees commented Jul 5, 2023

As far as I know: no ; trixeditor doesn't allow to insert HTML content.

@RachL
Copy link
Contributor

RachL commented Jul 5, 2023

@jibees have you check the last comment of the issue? openfoodfoundation/wishlist#63 (comment)

Also hr and br are html right? :p

@jibees
Copy link
Contributor

jibees commented Jul 5, 2023

I think I don't understand sorry.

Trixeditor can be tested here: https://trix-editor.org/ (or by staging the PR)

@RachL
Copy link
Contributor

RachL commented Jul 5, 2023

@jibees the 3rd accetpance criteria here says

Test <hr> and <br>

@jibees
Copy link
Contributor

jibees commented Jul 6, 2023

I missed that, you're right. Back in In dev since this still needs to implements horizontal rule, ie. <hr />(<br />is break in text or carriage-return and is simply implemented via an Enter character)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercut Labels papercuts after they've moved from the "Papercuts prioritized" column US Selected to be done by the US active instance
Projects
None yet
3 participants