-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUU] Change the columns to be shown in my catalogue #11055
Comments
I guess this is ready for dev since it seems to have been designed already. |
a similar inline button loading element has been implemented in the Connected Apps section in settings for Australia Let's talk about it during kickoff to avoid rebuilding too much |
scenario 1 and 2 not considered for this estimate, will be developed separately (note in #11200) |
Estimate
edit: Before starting, it will be worth a dev discussion. To consider:
|
@mariocarabotta to update, remove button and have autosave. |
Just pointing out that we are currently considering an alternative to StimulusReflex, so the second part of this (scenarios 7,8,9) will need further discussion. |
From memory, this is preferred because it's easier for the user, it's one less click. And it doesn't matter if they forget to save. But I think we might need a design for autosave. I can envisage two ways to design it:
Alternatively we stick to current behaviour as designed and described above. So, I think we can do option 1 without needing further design. |
I would not include any blurring, and I would consider starting without any saving feedback at all. Saving calls can succeed or fail in the background. What do you think? |
@mariocarabotta @dacook I'm sorry, I feel this comment comes after the party (I missed the previous comment about autosave), but are we sure we want to introduce autosave as part of the first release? I understand it may saves us time when developing, but we need to consider testing and potential bugs during first release. |
that's fair! I am not particularly attached to autosave, I think we were discussing making it a bit leaner (from an interaction point of view) a while ago, but the context and timeframe was different at that time. Given that having a manual save seems like it would be the easiest solution from a technical point of view, I am happy if we go ahead with that. |
Hi @dacook , @mariocarabotta - I found we are using multi-select dropdown in the reports as well and here's its design: However, as per the given mockup we want this design: Just wanted to confirm the path forward before moving forward:
Thanks. |
I believe it would be good to implement the new design. the ones in report have uppercase (hard to read), some spacing issues, no colors. But also conscious of timeframes, @RachL it would be good to get your view as well. We can also go ahead with using the existing report dropdown to speed things up. |
Thanks all. I suggest that we investigate if it's very easy to reuse the existing (Angular) component on this page. But if it's not easy, we should go ahead with building a new component. (I think we can still re-use the And so I don't think it's worth updating the report's dropdown yet. We can make the decision about that after this is done first. |
Yes unfortunately we need to aim at the quickest solutions now for BUU. Not only in terms of timeframes, but also in terms of budget (yes I know that rebuilding means more budget in the end, but that's what our cashflow situation forces us to do). |
ok that sounds reasonable. thanks! |
I'm going to try the spike now to see which path to take. |
Ok, I got a proof of concept going. It's actually not too bad, although there's a slight delay after page load before the preferred columns are shown/hidden. Remaining:
master...dacook:openfoodnetwork:buu/change-columns-11055-angular
I tried, failed, and am less happy with how it looks now. I'm going to pause on this for the moment and reconsider. |
Question: Do we want to keep user column preferences from the old screen and bring them to the new screen? So far, I've built it so that the preferences from each screen are separate. I think it won't be simple to share the column prefs between both screens because there are some differences (different order, and some different columns). I can see a couple of ways to do it:
Hmm.. I think it's not worth it, so will make the call and won't raise it further. That is, column preferences from the old screen will not be brought to the new screen. |
I'd say not worth it too..it's a few clicks away for people, not a big deal |
Context
This issue introduces the ability to change which columns to display in the table, and saving it as the default.
Description
- As an: enterprise user
- On page:
/admin/products
- I want to be able to: change the columns in my catalogue
- So that: I can see the information I need to manage my products effinciently
Acceptance Criteria & Tests
Scenario 1: Default - multiple producersMOVED TO #11200Scenario 2: Default - single producerMOVED TO #11200Scenario 3: Open dropdown
Given that my catalogue has loaded successfully
When I click on the columns button
Then I see a dropdown with all the available columns
And the ones displayed are selected
Scenario 4: Deselect column
Given the columns dropdown is open
When I de-select an option
Then the column gets hidden from the table
Scenario 5: Select column
Given the columns dropdown is open
When I select an option
Then the column gets displayed in the table
Scenario 6: Close dropdown without saving
Given the columns dropdown is open
And I have changed the columns to be displayed
When I close it
Then I see the selected columns only for the current session
Scenario 7: Save default
Given the columns dropdown is open
And I have changed the columns to be displayed
When I save them as default
Then the systems requests to save them
And I see a loading indicator
Scenario 8: Save successful
Given I am saving the default columns to display
When saving is successful
Then I see a success message
And the dropdown closes after 2 seconds
And the next time I load the page I will see the saved default columns
Scenario 9: Save failed
Given I am saving the default columns to display
When saving is not successful
Then I see a fail message
Design here > https://www.figma.com/file/ddL6h7H9It5ZmUuVYQxzAD/Product-List?type=design&node-id=544%3A11446&mode=design&t=r4sHF7R9Mxy8Lpx2-1
Design specs
Figma screens are available here >
https://www.figma.com/file/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?type=design&node-id=489%3A5377&mode=design&t=IIxsDCFfXpzBuHIb-1
Prototype here (open dropdown, select on hand, save) - note: this won't update the table underneath, it's more to show the dropdown itself > https://www.figma.com/proto/v1zbrWDZSRd3Nqoe0SJ2Sm/Engineering-Delivery---Back-Office?page-id=489%3A5377&type=design&node-id=489-5835&viewport=598%2C478%2C0.26&t=tqJxBkJp8YYHxusL-1&scaling=min-zoom&mode=design
New components and styles
The text was updated successfully, but these errors were encountered: