From 16b7626cd1b74716c6e43d20ccc03e798163444c Mon Sep 17 00:00:00 2001 From: cmontemuino <1761056+cmontemuino@users.noreply.github.com> Date: Fri, 15 Mar 2024 10:25:03 +0100 Subject: [PATCH] docs(chart): update topology segments usage Problem: It is not clear that `csi.node.topology.nodeSelector` is also impacting agent-ha-node daemonset Solution: Extend the `nodeSelector` documentation with a note that agent-ha-node node selector will be also updated with topology segments Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com> --- chart/README.md | 2 +- chart/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chart/README.md b/chart/README.md index 1b161af35..9ada64acf 100644 --- a/chart/README.md +++ b/chart/README.md @@ -133,7 +133,7 @@ This removes all the Kubernetes components associated with the chart and deletes | csi.​node.​resources.​requests.​cpu | Cpu requests for csi node plugin | `"100m"` | | csi.​node.​resources.​requests.​memory | Memory requests for csi node plugin | `"64Mi"` | | csi.​node.​tolerations | Set tolerations, overrides global | `[]` | -| csi.​node.​topology.​nodeSelector | Add topology segments to the csi-node daemonset node selector | `false` | +| csi.​node.​topology.​nodeSelector | Add topology segments to the csi-node and agent-ha-node daemonset node selector | `false` | | etcd.​autoCompactionMode | AutoCompaction Since etcd keeps an exact history of its keyspace, this history should be periodically compacted to avoid performance degradation and eventual storage space exhaustion. Auto compaction mode. Valid values: "periodic", "revision". - 'periodic' for duration based retention, defaulting to hours if no time unit is provided (e.g. 5m). - 'revision' for revision number based retention. | `"revision"` | | etcd.​autoCompactionRetention | Auto compaction retention length. 0 means disable auto compaction. | `100` | | etcd.​extraEnvVars[0] | Raise alarms when backend size exceeds the given quota. |
{
"name":"ETCD_QUOTA_BACKEND_BYTES",
"value":"8589934592"
}
| diff --git a/chart/values.yaml b/chart/values.yaml index e3337bd39..da722bf26 100644 --- a/chart/values.yaml +++ b/chart/values.yaml @@ -311,7 +311,7 @@ csi: topology: segments: openebs.io/csi-node: mayastor - # -- Add topology segments to the csi-node daemonset node selector + # -- Add topology segments to the csi-node and agent-ha-node daemonset node selector nodeSelector: false resources: limits: