Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "auto" option to language selector #1137

Open
Arnei opened this issue Aug 29, 2023 · 1 comment
Open

Add "auto" option to language selector #1137

Arnei opened this issue Aug 29, 2023 · 1 comment

Comments

@Arnei
Copy link
Member

Arnei commented Aug 29, 2023

The redesign introduced a language selector. It would be great to be able to set it to "auto", akin to the theme selector.

More context: #1079 (comment)

@lkiesow
Copy link
Member

lkiesow commented Aug 31, 2023

Unfortunately, it seems the translation library we use (react-18next) does not support an auto option out of the box. We certainly could work around that and make our own auto mode somehow, but it seems to me like that would take more time than I am willing to spent on it in this PR. Best left for another time.

If I remember correctly, it does support that to some extent: It already selects the language automatically, if none is stored in the local storage. So maybe just store to auto-mode separately and make sure to remove the stored i18m language before loading i18m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants