diff --git a/CHANGELOG.md b/CHANGELOG.md index 60b5bd3232..7b25da9c40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,8 @@ release. ([#460](https://github.com/open-telemetry/semantic-conventions/pull/460)) - Clarify that `client.port` is the port of whichever client was captured in `client.address`. ([#471](https://github.com/open-telemetry/semantic-conventions/pull/471)) +- Change `client.port` from recommended to opt-in on HTTP server spans + ([#472](https://github.com/open-telemetry/semantic-conventions/pull/472)) ### Features diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md index 4919481e88..00721efd60 100644 --- a/docs/http/http-spans.md +++ b/docs/http/http-spans.md @@ -341,7 +341,7 @@ For an HTTP server span, `SpanKind` MUST be `Server`. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| | [`client.address`](../general/attributes.md) | string | Client address - domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [1] | `83.164.160.102` | Recommended | -| [`client.port`](../general/attributes.md) | int | The port of whichever client was captured in `client.address`. [2] | `65123` | Recommended | +| [`client.port`](../general/attributes.md) | int | The port of whichever client was captured in `client.address`. [2] | `65123` | Opt-In | | [`http.route`](../attributes-registry/http.md) | string | The matched route, that is, the path template in the format used by the respective server framework. [3] | `/users/:userID?`; `{controller}/{action}/{id?}` | Conditionally Required: If and only if it's available | | [`network.local.address`](../attributes-registry/network.md) | string | Local socket address. Useful in case of a multi-IP host. | `10.1.2.80`; `/tmp/my.sock` | Opt-In | | [`network.local.port`](../attributes-registry/network.md) | int | Local socket port. Useful in case of a multi-port host. | `65123` | Opt-In | diff --git a/model/trace/http.yaml b/model/trace/http.yaml index e9f3146105..d67627ecb8 100644 --- a/model/trace/http.yaml +++ b/model/trace/http.yaml @@ -71,6 +71,7 @@ groups: Otherwise, the immediate client peer address. examples: ['83.164.160.102'] - ref: client.port + requirement_level: opt_in brief: The port of whichever client was captured in `client.address`. - ref: url.path requirement_level: required