From d1414a3653cd6d45a4dbf3a5c5b3ec9cd3066ad0 Mon Sep 17 00:00:00 2001 From: Steve Rao Date: Fri, 22 Mar 2024 23:46:56 +0800 Subject: [PATCH 1/3] Remove an extra letter in tracestate-probability-sampling.md Remove an extra letter in tracestate-probability-sampling.md --- specification/trace/tracestate-probability-sampling.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/tracestate-probability-sampling.md b/specification/trace/tracestate-probability-sampling.md index e1e33d503d8..72961b907b4 100644 --- a/specification/trace/tracestate-probability-sampling.md +++ b/specification/trace/tracestate-probability-sampling.md @@ -222,7 +222,7 @@ incomplete if the span's parent span was not collected. Incomplete traces that result from sampling configuration (i.e., on purpose) are known as partial traces. An important subset of the partial traces are those which are also complete subtraces. A -complete subtrace is defined at span S when every descendent span is +complete subtrace is defined at span when every descendent span is collected. Since the test for an incompleteness is one-way, it is important to From cef0b6e478fdcda7feaee36c949a9f78e186183f Mon Sep 17 00:00:00 2001 From: Steve Rao Date: Sat, 23 Mar 2024 00:22:19 +0800 Subject: [PATCH 2/3] Update specification/trace/tracestate-probability-sampling.md Co-authored-by: Tyler Yahn --- specification/trace/tracestate-probability-sampling.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/tracestate-probability-sampling.md b/specification/trace/tracestate-probability-sampling.md index 72961b907b4..c7fa0ad4f1f 100644 --- a/specification/trace/tracestate-probability-sampling.md +++ b/specification/trace/tracestate-probability-sampling.md @@ -222,7 +222,7 @@ incomplete if the span's parent span was not collected. Incomplete traces that result from sampling configuration (i.e., on purpose) are known as partial traces. An important subset of the partial traces are those which are also complete subtraces. A -complete subtrace is defined at span when every descendent span is +complete subtrace is defined at a span when every descendent span is collected. Since the test for an incompleteness is one-way, it is important to From 23099a3256758668a0f55cdae7f479ae5a266936 Mon Sep 17 00:00:00 2001 From: chengpu Date: Sat, 23 Mar 2024 00:41:49 +0800 Subject: [PATCH 3/3] Polish the docs --- specification/trace/tracestate-probability-sampling.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/trace/tracestate-probability-sampling.md b/specification/trace/tracestate-probability-sampling.md index c7fa0ad4f1f..e42b680511e 100644 --- a/specification/trace/tracestate-probability-sampling.md +++ b/specification/trace/tracestate-probability-sampling.md @@ -222,7 +222,7 @@ incomplete if the span's parent span was not collected. Incomplete traces that result from sampling configuration (i.e., on purpose) are known as partial traces. An important subset of the partial traces are those which are also complete subtraces. A -complete subtrace is defined at a span when every descendent span is +complete subtrace is defined at a span when every descendant span is collected. Since the test for an incompleteness is one-way, it is important to @@ -820,7 +820,7 @@ tracestate, we have the following cases: 3. If `TraceIDRatioBased` changes the sampling decision from yes to no, the consumer will observe singleton trace with correct adjusted count. The consumer cannot determine that R has two unsampled - descendents. + descendants. As these cases demonstrate, users can expect incompleteness and unknown adjusted count when using `TraceIDRatioBased` samplers for