From dedde4fbf92c82e8fa5b1e0f682fe3ed36d1aea8 Mon Sep 17 00:00:00 2001 From: Pierre Tessier Date: Sun, 3 Dec 2023 16:45:52 -0500 Subject: [PATCH 1/2] add attributes to kafka spans Signed-off-by: Pierre Tessier --- src/accountingservice/kafka/consumer.go | 2 +- src/accountingservice/kafka/trace_interceptor.go | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/accountingservice/kafka/consumer.go b/src/accountingservice/kafka/consumer.go index 56d82e08c2..1599a507ae 100644 --- a/src/accountingservice/kafka/consumer.go +++ b/src/accountingservice/kafka/consumer.go @@ -24,7 +24,7 @@ func StartConsumerGroup(ctx context.Context, brokers []string, log *logrus.Logge saramaConfig.Version = ProtocolVersion // So we can know the partition and offset of messages. saramaConfig.Producer.Return.Successes = true - saramaConfig.Consumer.Interceptors = []sarama.ConsumerInterceptor{NewOTelInterceptor()} + saramaConfig.Consumer.Interceptors = []sarama.ConsumerInterceptor{NewOTelInterceptor(GroupID)} consumerGroup, err := sarama.NewConsumerGroup(brokers, GroupID, saramaConfig) if err != nil { diff --git a/src/accountingservice/kafka/trace_interceptor.go b/src/accountingservice/kafka/trace_interceptor.go index 9ff2d3bf11..60fdb440a5 100644 --- a/src/accountingservice/kafka/trace_interceptor.go +++ b/src/accountingservice/kafka/trace_interceptor.go @@ -21,12 +21,13 @@ type OTelInterceptor struct { // NewOTelInterceptor processes span for intercepted messages and add some // headers with the span data. -func NewOTelInterceptor() *OTelInterceptor { +func NewOTelInterceptor(groupID string) *OTelInterceptor { oi := OTelInterceptor{} oi.tracer = otel.Tracer("github.com/open-telemetry/opentelemetry-demo/accountingservice/sarama") oi.fixedAttrs = []attribute.KeyValue{ semconv.MessagingSystem("kafka"), + semconv.MessagingKafkaConsumerGroup(groupID), semconv.NetTransportTCP, } return &oi @@ -50,6 +51,8 @@ func (oi *OTelInterceptor) OnConsume(msg *sarama.ConsumerMessage) { trace.WithAttributes( semconv.MessagingDestinationKindTopic, semconv.MessagingDestinationName(msg.Topic), + semconv.MessagingKafkaMessageOffset(int(msg.Offset)), + semconv.MessagingMessagePayloadSizeBytes(len(msg.Value)), semconv.MessagingOperationReceive, semconv.MessagingKafkaDestinationPartition(int(msg.Partition)), ), From 88959636f18d2b9d7e1e49ce6ceadff07d035cdf Mon Sep 17 00:00:00 2001 From: Pierre Tessier Date: Sun, 3 Dec 2023 16:50:18 -0500 Subject: [PATCH 2/2] add attributes to kafka spans Signed-off-by: Pierre Tessier --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 17dc0c89e0..6d0b7b31e6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,10 @@ release. ([#1236](https://github.com/open-telemetry/opentelemetry-demo/pull/1236)) * [cartservice] Add .NET memory, CPU, and thread metrics ([#1265](https://github.com/open-telemetry/opentelemetry-demo/pull/1265)) -* enable browser traffic in loadgenerator using playwright ([#1266](https://github.com/open-telemetry/opentelemetry-demo/pull/1266)) +* enable browser traffic in loadgenerator using playwright + ([#1266](https://github.com/open-telemetry/opentelemetry-demo/pull/1266)) +* [accountingservice] Add additional attributes to Kafka spans + ([#1286](https://github.com/open-telemetry/opentelemetry-demo/pull/1286)) ## 1.6.0