From 666b56c2b650f4a7270a0652fa64aa83bae8f5de Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Wed, 24 Apr 2024 14:26:50 -0500 Subject: [PATCH 01/11] Define specification sponsor and seed with spec approvers --- community-members.md | 20 +++++------ community-membership.md | 79 +++++++++++++++++++++++++++++++++++++---- 2 files changed, 80 insertions(+), 19 deletions(-) diff --git a/community-members.md b/community-members.md index 8fa2459a..a261789d 100644 --- a/community-members.md +++ b/community-members.md @@ -45,23 +45,19 @@ Members of the Technical Committee are the maintainers of [Project specs](https://github.com/open-telemetry/opentelemetry-specification) and [Proto definitions](https://github.com/open-telemetry/opentelemetry-proto). -Trace Approvers: +[Specification sponsors](./community-membership.md#specification-sponsor) are +trusted collaborators of the Technical Committee on Project specs and related +repositories: +- [Christian Beedgen](https://github.com/kumoroku), Sumo Logic - [Christian Neumüller](https://github.com/Oberon00), Dynatrace -- [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk -- [Ted Young](https://github.com/tedsuo), Lightstep - -Metrics Approvers: - - [Cijo Thomas](https://github.com/cijothomas), Microsoft -- [Leighton Chen](https://github.com/lzchen), Microsoft -- [Tyler Yahn](https://github.com/MrAlias), Splunk - -Logs Approvers: - -- [Christian Beedgen](https://github.com/kumoroku), Sumo Logic - [Daniel Jaglowski](https://github.com/djaglowski), observIQ - [David Poncelow](https://github.com/zenmoto), Splunk +- [Leighton Chen](https://github.com/lzchen), Microsoft +- [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk +- [Ted Young](https://github.com/tedsuo), Lightstep +- [Tyler Yahn](https://github.com/MrAlias), Splunk ## Semantic Conventions diff --git a/community-membership.md b/community-membership.md index 5ee95fe9..20031916 100644 --- a/community-membership.md +++ b/community-membership.md @@ -8,13 +8,14 @@ Group). Responsibilities for most roles are scoped to these subprojects (repos). The OpenTelemetry [Governance Committee][] owns this document and process until delegated. They can be reached via e-mail . -| **Role** | **Responsibilities** | **Requirements** | **Defined by** | -| ---------- | ----------------------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------------ | -| member | active contributor in the community. reviewer of PRs | sponsored by 2 approvers or maintainers. multiple contributions to the project. | OpenTelemetry GitHub org member. | -| triager | assist with project management and backlog organization. | nominated by a maintainer. help with issues for one month. | CONTRIBUTING, CODEOWNERS, or the README. | -| approver | approve incoming contributions | highly experienced and active reviewer + contributor to a subproject | [CODEOWNERS](https://help.github.com/en/articles/about-code-owners) in GitHub | -| maintainer | set direction and priorities for a subproject | demonstrated responsibility and excellent technical judgement for the subproject | [CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repo ownership in GitHub | -| emeritus | position of honor for former maintainers, approvers, and triagers | must have previously held a community role and not have been removed from that role for a [Code of Conduct](code-of-conduct.md) violation. | Listed as an emeritus maintainer/approver/triager in CONTRIBUTING, CODEOWNERS, or README | +| **Role** | **Responsibilities** | **Requirements** | **Defined by** | +|-----------------------|-------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------| +| member | active contributor in the community. reviewer of PRs | sponsored by 2 approvers or maintainers. multiple contributions to the project. | OpenTelemetry GitHub org member. | +| triager | assist with project management and backlog organization. | nominated by a maintainer. help with issues for one month. | CONTRIBUTING, CODEOWNERS, or the README. | +| approver | approve incoming contributions | highly experienced and active reviewer + contributor to a subproject | [CODEOWNERS](https://help.github.com/en/articles/about-code-owners) in GitHub | +| maintainer | set direction and priorities for a subproject | demonstrated responsibility and excellent technical judgement for the subproject | [CODEOWNERS](https://help.github.com/en/articles/about-code-owners), GitHub Team and repo ownership in GitHub | +| emeritus | position of honor for former maintainers, approvers, and triagers | must have previously held a community role and not have been removed from that role for a [Code of Conduct](code-of-conduct.md) violation. | Listed as an emeritus maintainer/approver/triager in CONTRIBUTING, CODEOWNERS, or README | +| specification sponsor | trusted collaborators for the specification | nominated by [Technical Committee][] | Listed in [Community Members -> Specification and Protos](./community-members.md#specifications-and-proto) | ## New contributors @@ -296,5 +297,69 @@ with the project. When a contributor returns to being more active, they may be promoted back to their previous position at the discretion of the current maintainers following the process defined above. +## Specification Sponsor + +Specification sponsors are trusted collaborators of the technical committee, and +work to review, approve, and sponsor [opentelemetry-specification][] issues and +PRs. + +Members are defined +in [Community Members -> Specification and Protos](./community-members.md#specifications-and-proto) +and are members of the `spec-sponsors` team (TODO: add link to github team when +available). Specification sponsors SHOULD list +their [areas of interest](./areas-of-interest.md). + +### Requirements + +Specification sponsors are trusted to drive specification work which can be +complex and which highly impactful to downstream language SIGs and to the +OpenTelemetry project as a whole. Approvals from specification sponsors count +towards the approvals required to merge specification PRs. Therefore, there is a +high bar to becoming a specification sponsor. + +- Contributor to OpenTelemetry project for at least 1 year +- Has been the reviewer or author (through the sponsorship of another + specification sponsor) of at least 10 substantial PRs to specification or + related repositories +- Demonstrated sound technical judgement, and a deep understanding of the + specification and the OpenTelemetry project +- Nominated by technical committee member ( + see [becoming a specification sponsor](#becoming-a-specification-sponsor)) + +### Responsibilities and privileges + +- Review, respond to, and approve issues / PRs when tagged or when within areas + of interest (inactivity for more than 1 month when tagged may result in + suspension until active again) +- Sponsor issues, taking responsibility to be point on requirement gathering, + developing solutions and prototypes, writing PRs, and responding to / + incorporating PR feedback. This can be done by the sponsor themselves, or by + another collaborator who is sponsored. If sponsoring another collaborator, the + sponsor should work with them to ensure the work is consistent with existing + specification. +- Demonstrate sound technical judgement (may be asked to step down by a + technical committee member if they lose confidence of technical committee) + +### Becoming a Specification Sponsor + +Technical committee members nominate specification sponsors by opening a PR to +the community repo to add the nominee to the specification sponsor list. The +vote is officially started when a pull request is opened, and ends when the pull +request is merged. The pull request may be merged when the following conditions +are met: + +- The person being nominated has accepted the nomination by approving the pull + request. +- All TC members have approved the pull request or a majority of TC members have + approved the pull request and no other TC member has objected by requesting + changes on the pull request. In the case that all TC members have not given + approval, the pull request should stay open for a minimum of 5 days before + merging. + +The nominee is considered a specification sponsor after the pull request is +merged. The merger should update the `spec-sponsors` team with the new member. + [Governance Committee]: ./governance-charter.md +[Technical Committee]: ./tech-committee-charter.md +[opentelemetry-specification]: https://github.com/open-telemetry/opentelemetry-specification [Members of Standing]: ./governance-charter.md#members-of-standing From 9e3e92c0cdb28803bc3dc4571c521f54d62a74dd Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Wed, 24 Apr 2024 14:57:24 -0500 Subject: [PATCH 02/11] spellcheck --- .cspell.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cspell.yaml b/.cspell.yaml index 1dc272a7..770df5fd 100644 --- a/.cspell.yaml +++ b/.cspell.yaml @@ -146,6 +146,7 @@ words: - pmpaulino - poncelow - proto + - protos - pyohannes - pytest - reiley From 8813c7eda1e1a9d45a26b969c3ccf66a82c69ae6 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Tue, 30 Apr 2024 11:31:11 -0500 Subject: [PATCH 03/11] encourage moving to emeritus --- community-membership.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/community-membership.md b/community-membership.md index 20031916..d44a9679 100644 --- a/community-membership.md +++ b/community-membership.md @@ -312,7 +312,7 @@ their [areas of interest](./areas-of-interest.md). ### Requirements Specification sponsors are trusted to drive specification work which can be -complex and which highly impactful to downstream language SIGs and to the +complex and highly impactful to downstream language SIGs and to the OpenTelemetry project as a whole. Approvals from specification sponsors count towards the approvals required to merge specification PRs. Therefore, there is a high bar to becoming a specification sponsor. @@ -329,8 +329,7 @@ high bar to becoming a specification sponsor. ### Responsibilities and privileges - Review, respond to, and approve issues / PRs when tagged or when within areas - of interest (inactivity for more than 1 month when tagged may result in - suspension until active again) + of interest - Sponsor issues, taking responsibility to be point on requirement gathering, developing solutions and prototypes, writing PRs, and responding to / incorporating PR feedback. This can be done by the sponsor themselves, or by @@ -340,6 +339,11 @@ high bar to becoming a specification sponsor. - Demonstrate sound technical judgement (may be asked to step down by a technical committee member if they lose confidence of technical committee) +Sponsors who are unable to fulfill their responsibilities (e.g. no longer have +time available to commit) are expected to be moved +to [emeritus](#emeritus-maintainerapprovertriager) sponsors. The TC may also +vote to move a sponsor to emeritus. + ### Becoming a Specification Sponsor Technical committee members nominate specification sponsors by opening a PR to From 011e89e8eaacbf64e5b9badaff728848668ed4c9 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Tue, 7 May 2024 16:35:27 -0500 Subject: [PATCH 04/11] PR feedback --- community-membership.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/community-membership.md b/community-membership.md index d44a9679..8d2fa5e7 100644 --- a/community-membership.md +++ b/community-membership.md @@ -329,15 +329,14 @@ high bar to becoming a specification sponsor. ### Responsibilities and privileges - Review, respond to, and approve issues / PRs when tagged or when within areas - of interest + of interest. - Sponsor issues, taking responsibility to be point on requirement gathering, developing solutions and prototypes, writing PRs, and responding to / incorporating PR feedback. This can be done by the sponsor themselves, or by another collaborator who is sponsored. If sponsoring another collaborator, the sponsor should work with them to ensure the work is consistent with existing specification. -- Demonstrate sound technical judgement (may be asked to step down by a - technical committee member if they lose confidence of technical committee) +- Demonstrate sound technical judgement. Sponsors who are unable to fulfill their responsibilities (e.g. no longer have time available to commit) are expected to be moved From 032431163f4386456a5eaa57122f07ef41c57c29 Mon Sep 17 00:00:00 2001 From: Armin Ruech <7052238+arminru@users.noreply.github.com> Date: Fri, 17 May 2024 18:24:22 +0200 Subject: [PATCH 05/11] Fix conflict in .cspell.yaml --- .cspell.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.cspell.yaml b/.cspell.yaml index 89430fca..226d1d7e 100644 --- a/.cspell.yaml +++ b/.cspell.yaml @@ -135,7 +135,6 @@ words: - poncelow - proto - protos - - pyohannes - pytest - raesene - reiley From ec0e3016547ae7ace87639e3aac3407eb225afff Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Mon, 20 May 2024 17:28:13 -0500 Subject: [PATCH 06/11] Add frequent spec attendance to responsibilities --- community-membership.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/community-membership.md b/community-membership.md index 8d2fa5e7..849c20db 100644 --- a/community-membership.md +++ b/community-membership.md @@ -337,6 +337,8 @@ high bar to becoming a specification sponsor. sponsor should work with them to ensure the work is consistent with existing specification. - Demonstrate sound technical judgement. +- Frequently attend the specification SIG meeting where issues and PRs are + synchronously discussed. Sponsors who are unable to fulfill their responsibilities (e.g. no longer have time available to commit) are expected to be moved From 37743ce8a8590614ba77521391b7c98884decd62 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Tue, 21 May 2024 10:35:18 -0500 Subject: [PATCH 07/11] Fix emeritus --- community-members.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/community-members.md b/community-members.md index e5cef550..23f9cc7b 100644 --- a/community-members.md +++ b/community-members.md @@ -53,16 +53,17 @@ repositories: - [Christian Neumüller](https://github.com/Oberon00), Dynatrace - [Cijo Thomas](https://github.com/cijothomas), Microsoft - [Daniel Jaglowski](https://github.com/djaglowski), observIQ -- [Robert Pająk](https://github.com/pellared), Splunk - -Logs Approvers Emeritus: - -- [David Poncelow](https://github.com/zenmoto), Splunk - [Leighton Chen](https://github.com/lzchen), Microsoft - [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk +- [Robert Pająk](https://github.com/pellared), Splunk - [Ted Young](https://github.com/tedsuo), Lightstep - [Tyler Yahn](https://github.com/MrAlias), Splunk +Emeritus sponsors (formerly approvers): + +- [David Poncelow](https://github.com/zenmoto), Splunk + + ## Semantic Conventions Repo: [open-telemetry/semantic-conventions](https://github.com/open-telemetry/semantic-conventions) From f42e0d79dcdca6b0f1447b1e36738846a412b13b Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Wed, 22 May 2024 12:53:07 -0500 Subject: [PATCH 08/11] Move Nikita to emeritus --- community-members.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/community-members.md b/community-members.md index 23f9cc7b..6b384e39 100644 --- a/community-members.md +++ b/community-members.md @@ -54,7 +54,6 @@ repositories: - [Cijo Thomas](https://github.com/cijothomas), Microsoft - [Daniel Jaglowski](https://github.com/djaglowski), observIQ - [Leighton Chen](https://github.com/lzchen), Microsoft -- [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk - [Robert Pająk](https://github.com/pellared), Splunk - [Ted Young](https://github.com/tedsuo), Lightstep - [Tyler Yahn](https://github.com/MrAlias), Splunk @@ -62,7 +61,7 @@ repositories: Emeritus sponsors (formerly approvers): - [David Poncelow](https://github.com/zenmoto), Splunk - +- [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk ## Semantic Conventions From 44e33ab7177afe2b176b0f6113d6f6b83bbaae93 Mon Sep 17 00:00:00 2001 From: Jack Berg Date: Thu, 23 May 2024 09:03:05 -0500 Subject: [PATCH 09/11] Move Christian and Leighton to emeritus --- community-members.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/community-members.md b/community-members.md index 6b384e39..4d1ff3f1 100644 --- a/community-members.md +++ b/community-members.md @@ -49,18 +49,18 @@ and [Proto definitions](https://github.com/open-telemetry/opentelemetry-proto). trusted collaborators of the Technical Committee on Project specs and related repositories: -- [Christian Beedgen](https://github.com/kumoroku), Sumo Logic - [Christian Neumüller](https://github.com/Oberon00), Dynatrace - [Cijo Thomas](https://github.com/cijothomas), Microsoft - [Daniel Jaglowski](https://github.com/djaglowski), observIQ -- [Leighton Chen](https://github.com/lzchen), Microsoft - [Robert Pająk](https://github.com/pellared), Splunk - [Ted Young](https://github.com/tedsuo), Lightstep - [Tyler Yahn](https://github.com/MrAlias), Splunk Emeritus sponsors (formerly approvers): +- [Christian Beedgen](https://github.com/kumoroku), Sumo Logic - [David Poncelow](https://github.com/zenmoto), Splunk +- [Leighton Chen](https://github.com/lzchen), Microsoft - [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk ## Semantic Conventions From a6c7249621287fa7a461911878672349a632eaf5 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 10 Jun 2024 11:55:23 -0700 Subject: [PATCH 10/11] Update community-members.md Co-authored-by: Daniel Jaglowski --- community-members.md | 1 - 1 file changed, 1 deletion(-) diff --git a/community-members.md b/community-members.md index a48c1478..4af186ac 100644 --- a/community-members.md +++ b/community-members.md @@ -52,7 +52,6 @@ repositories: - [Christian Neumüller](https://github.com/Oberon00), Dynatrace - [Cijo Thomas](https://github.com/cijothomas), Microsoft -- [Daniel Jaglowski](https://github.com/djaglowski), observIQ - [Robert Pająk](https://github.com/pellared), Splunk - [Ted Young](https://github.com/tedsuo), Lightstep - [Tyler Yahn](https://github.com/MrAlias), Splunk From 12202c912fedc2171f25e9080bde3236ca974fce Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Mon, 10 Jun 2024 11:55:30 -0700 Subject: [PATCH 11/11] Update community-members.md Co-authored-by: Daniel Jaglowski --- community-members.md | 1 + 1 file changed, 1 insertion(+) diff --git a/community-members.md b/community-members.md index 4af186ac..a2357702 100644 --- a/community-members.md +++ b/community-members.md @@ -59,6 +59,7 @@ repositories: Emeritus sponsors (formerly approvers): - [Christian Beedgen](https://github.com/kumoroku), Sumo Logic +- [Daniel Jaglowski](https://github.com/djaglowski), observIQ - [David Poncelow](https://github.com/zenmoto), Splunk - [Leighton Chen](https://github.com/lzchen), Microsoft - [Nikita Salnikov-Tarnovski](https://github.com/iNikem), Splunk