Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Chinese translation of Generation datasets #665

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

ckkelvinchan
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #665 (ef92fba) into master (34d39c8) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   80.49%   80.65%   +0.15%     
==========================================
  Files         198      199       +1     
  Lines       11234    11371     +137     
  Branches     1795     1818      +23     
==========================================
+ Hits         9043     9171     +128     
- Misses       1915     1916       +1     
- Partials      276      284       +8     
Flag Coverage Δ
unittests 80.63% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/restorers/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/pipelines/__init__.py 100.00% <0.00%> (ø)
mmedit/models/restorers/real_basicvsr.py 87.01% <0.00%> (ø)
mmedit/datasets/pipelines/crop.py 97.24% <0.00%> (+0.20%) ⬆️
mmedit/datasets/pipelines/random_degradations.py 94.68% <0.00%> (+0.79%) ⬆️
...edit/models/components/discriminators/unet_disc.py 87.50% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d39c8...ef92fba. Read the comment docs.

@@ -1 +1,8 @@
# 数据集 - 生成
# 生成数据集
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议改为“图像生成”,更具体一点。
如果更近一步建议改为图像转译,即 image translation,因为这个repo似乎不涉及单纯的GAN的内容。但考虑到和其他文档的一致性也可以先不改。

@@ -11,3 +11,21 @@
year={2017}
}
```

您可以从[此处](https://people.eecs.berkeley.edu/~taesung_park/CycleGAN/datasets/)下载未配对的数据集。然后,您需要解压缩并移动相应的数据集以遵循如上所示的文件夹结构。数据集由原作者精心准备。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datasets have been well-prepared by the original authors.

数据集已经由原作者准备好了。

@@ -11,3 +11,19 @@
year={2017}
}
```

您可以从[此处](http://efrosgans.eecs.berkeley.edu/pix2pix/datasets/)下载配对数据集。然后,您需要解压缩并移动相应的数据集以遵循如下所示的文件夹结构。数据集由原作者精心准备。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datasets have been well-prepared by the original authors.

数据集已经由原作者准备好了。

@ckkelvinchan ckkelvinchan merged commit 5851c20 into open-mmlab:master Dec 21, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants