Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add SRFacicalLandmarkDataset. #329

Merged
merged 3 commits into from
May 31, 2021
Merged

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #329 (d992e6e) into master (6238c69) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   80.03%   80.09%   +0.05%     
==========================================
  Files         178      179       +1     
  Lines        9332     9349      +17     
  Branches     1357     1359       +2     
==========================================
+ Hits         7469     7488      +19     
+ Misses       1674     1673       -1     
+ Partials      189      188       -1     
Flag Coverage Δ
unittests 80.07% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/sr_facical_landmark_dataset.py 100.00% <100.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6238c69...d992e6e. Read the comment docs.

mmedit/datasets/sr_landmark_dataset.py Outdated Show resolved Hide resolved
mmedit/datasets/sr_landmark_dataset.py Outdated Show resolved Hide resolved
mmedit/datasets/sr_landmark_dataset.py Outdated Show resolved Hide resolved
@innerlee innerlee changed the title [Feature] Add SRLandmarkDataset. [Feature] Add SRFacicalLandmarkDataset. May 31, 2021
dict: Returned dict for GT and landmark.
Contains: gt_path, bbox, shape, landmark.
"""
data_infos = np.load(self.ann_file, allow_pickle=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use mmcv.load. Benefit: it will support json automatically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't support "npy" file, and here we don't need JSON data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@innerlee
Copy link
Contributor

A minor change

@innerlee innerlee merged commit ca9ff82 into open-mmlab:master May 31, 2021
@Yshuo-Li Yshuo-Li deleted the sld branch May 31, 2021 05:13
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Add SRLandmarkDataset.

* Update docstring

* Rename

Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants