Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update pytorch2onnx #265

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

grimoire
Copy link
Member

Hi,
This PR adds restorer model support to pytorch2onnx.
Dynamic shape, dynamic batch and visualize support are also added too.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #265 (203cb80) into master (2541089) will decrease coverage by 1.40%.
The diff coverage is 15.51%.

❗ Current head 203cb80 differs from pull request most recent head b57d7c6. Consider uploading reports for the commit b57d7c6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   81.34%   79.93%   -1.41%     
==========================================
  Files         158      159       +1     
  Lines        7773     7941     +168     
  Branches     1152     1177      +25     
==========================================
+ Hits         6323     6348      +25     
- Misses       1306     1449     +143     
  Partials      144      144              
Flag Coverage Δ
unittests 79.93% <15.51%> (-1.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/restoration_inference.py 16.66% <0.00%> (ø)
mmedit/apis/test.py 25.25% <0.00%> (-0.53%) ⬇️
...edit/models/backbones/sr_backbones/basicvsr_net.py 87.87% <0.00%> (-0.68%) ⬇️
mmedit/models/backbones/sr_backbones/iconvsr.py 14.10% <14.10%> (ø)
mmedit/models/restorers/basicvsr.py 69.23% <27.27%> (-4.27%) ⬇️
mmedit/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmedit/models/backbones/sr_backbones/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2541089...b57d7c6. Read the comment docs.

tools/pytorch2onnx.py Outdated Show resolved Hide resolved
tools/pytorch2onnx.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innerlee innerlee merged commit 972ef7e into open-mmlab:master Apr 23, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* add restorer model onnx support, add visualize

* use cv2 instead of matplotlib

* fix dynamic batch output axis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants