Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add matplotlib minimum version requriments. #909

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

tpoisonooo
Copy link

@tpoisonooo tpoisonooo commented Jul 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix show_result error.

fig.add_subplot() == None when matplotlib==3.0.3, here is my callstack:

> /home/PJLAB/konghuanjun/GitProjects/mmclassification/mmcls/core/visualization/image.py(68)_initialize_fig_save()
-> ax = fig.add_subplot()
(Pdb) p fig
<Figure size 230.4x172.8 with 0 Axes>
(Pdb) n
> /home/PJLAB/konghuanjun/GitProjects/mmclassification/mmcls/core/visualization/image.py(71)_initialize_fig_save()
-> fig.subplots_adjust(left=0, right=1, bottom=0, top=1)
(Pdb) p ax
None
...
(Pdb) matplotlib.__version__
'3.0.3'

"In matplotlib < 3.1 you will need to explicitly state the position of the subplot in the grid"
https://stackoverflow.com/questions/56632987/matplotlib-figure-figure-add-subplots-and-add-axes-return-none-instead-of-ax

Modification

update requirements.txt

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@tpoisonooo tpoisonooo changed the title Update runtime.txt fix(mmcls/core/visualization/image.py): fig.add_subploat == None Jul 11, 2022
@tpoisonooo tpoisonooo changed the title fix(mmcls/core/visualization/image.py): fig.add_subploat == None fix(mmcls/core/visualization/image.py): fig.add_subplot()==None Jul 11, 2022
@mzr1996 mzr1996 changed the title fix(mmcls/core/visualization/image.py): fig.add_subplot()==None [Fix] Add matplotlib minimum version requriments. Sep 30, 2022
@mzr1996 mzr1996 changed the base branch from master to dev September 30, 2022 06:22
@mzr1996 mzr1996 merged commit 27b0bd5 into open-mmlab:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants