Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add brief installation steps in README for copy&paste #755

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[Docs] Add brief installation steps in README for copy&paste #755

merged 2 commits into from
Mar 30, 2022

Conversation

yingfhu
Copy link
Collaborator

@yingfhu yingfhu commented Mar 30, 2022

Motivation

This is an implantation from MMEditing #816

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@yingfhu yingfhu changed the base branch from master to dev March 30, 2022 09:32
@yingfhu yingfhu requested a review from mzr1996 March 30, 2022 09:33
mzr1996
mzr1996 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 34dd328 into open-mmlab:dev Mar 30, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@yingfhu
[Docs] Add brief installation steps in README for copy&paste. (open-m…
a70b1ff 
…mlab#755)

* [Docs] Add breif installation code for copy&paste.

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzr1996 mzr1996 mzr1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yingfhu @mzr1996