-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Use post_process
function to handle pred result processing.
#390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 76.51% 76.56% +0.05%
==========================================
Files 97 97
Lines 5224 5206 -18
Branches 856 852 -4
==========================================
- Hits 3997 3986 -11
+ Misses 1108 1101 -7
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Did |
Yes, share the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
open-mmlab#390) Use post_process function to handle pred result processing in `simple_test`.
Motivation
In most heads, we need to do some post-processing after getting the pred result. However, downstream tasks, like deploy, may want to override this post-processing function.
Modification
Convert the post-processing in the
simple_test
function to a standalone method. And all child classes can reuse the method.BC-breaking (Optional)
No.
Checklist
Before PR:
After PR: