Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy tests #151

Open
DavisRayM opened this issue Jan 16, 2020 · 2 comments · May be fixed by #167
Open

Add mypy tests #151

DavisRayM opened this issue Jan 16, 2020 · 2 comments · May be fixed by #167
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@DavisRayM
Copy link
Contributor

mypy is a static type checker for python. Implementing tests using it will help ensure our functions are receiving and outputting the correct type of data.

Read more about mypy here and here.

Sub-Issue of #150
@DavisRayM DavisRayM added enhancement New feature or request help wanted Extra attention is needed labels Jan 16, 2020
@DavisRayM
Copy link
Contributor Author

DavisRayM commented Jan 16, 2020 •
edited
Loading

This issue entails the following tasks:

  • Revisiting functions implemented currently and testing them with mypy
  • Run mypy tests on travis? --> Add mypy test to tox
  • Add to pre-commit --> This step is blocked by Add a pre-commit #154.

@moshthepitt
Copy link
Contributor

Ideas:

This was referenced Jan 16, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mypy onaio/tasking
2 participants
@moshthepitt @DavisRayM