Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework plugins #111

Closed
olov opened this issue Nov 19, 2014 · 3 comments
Closed

Rework plugins #111

olov opened this issue Nov 19, 2014 · 3 comments

Comments

@olov
Copy link
Owner

olov commented Nov 19, 2014

The plugin API is super-experimental haven't been kept up to date. The API as it once was created focused a lot on extensibility it terms of matching rather than providing usable output for other tools (the latter is probably more useful).

The API as it looks right now should most likely be deprecated in favor of a new, improved (and documented) API. I welcome contributions in this area!

@diwu1989
Copy link

I just wrote a plugin today and I had to look into the source code of ngAnnotate and ngInject to learn how it works, but it didn't take too much effort to write a plugin for what I needed. I think if you just had a few examples of plugins for people to look at, then it'd be a lot easier to use. The current API seems okay, having examples would have been enough for me.

@vatula
Copy link

vatula commented May 18, 2015

I found it almost okay. The usage of custom attributes on nodes like $chained etc is obscure though and I still don't understand what needs to be returned by the plugin. A function that needs guards?

@olov
Copy link
Owner Author

olov commented Jun 8, 2016

#245

@olov olov closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants