You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Github has features which close a linked issue when a PR is merged (possibly just to the main branch): special tags in commits (closes, fixes, ...) or manually linked issues (to test how this behaves).
In the context of the mergebot, and odoo's workflow, this is a problem:
the commit tags only work from the main branch, as Odoo PRs are mostly not merged in the main branch a lot of fixes will never land there
Apparently it's possible to retrieve linked PRs but only in the v4 API via PullRequest.closingIssuesReferences. Though at least that looks pre-filtered by applicable issues (aka only those this PR will close). This means on merging a PR we could retrieve this list and close all the linked issues. A bit of a pain because GQL but it'd be done via a cron anyway (as we'd need to be sure the PR was successfully merged before even checking) so should be feasible via an ad-hoc GQL query.
The text was updated successfully, but these errors were encountered:
Github has features which close a linked issue when a PR is merged (possibly just to the main branch): special tags in commits (
closes
,fixes
, ...) or manually linked issues (to test how this behaves).In the context of the mergebot, and odoo's workflow, this is a problem:
Apparently it's possible to retrieve linked PRs but only in the v4 API via
PullRequest.closingIssuesReferences
. Though at least that looks pre-filtered by applicable issues (aka only those this PR will close). This means on merging a PR we could retrieve this list and close all the linked issues. A bit of a pain because GQL but it'd be done via a cron anyway (as we'd need to be sure the PR was successfully merged before even checking) so should be feasible via an ad-hoc GQL query.The text was updated successfully, but these errors were encountered: