Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v231214-dashboard-support headline #3130

Closed
sync-by-unito bot opened this issue Dec 5, 2023 · 17 comments
Closed

v231214-dashboard-support headline #3130

sync-by-unito bot opened this issue Dec 5, 2023 · 17 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 5, 2023

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

C

﹍Release note:﹍

﹍Expectation:﹍

  1. Support headline
  2. align folder name with Capture Cam
  3. fixed sign_metadata format

﹍Known Issue:﹍

Known issues collection (Dashboard)

﹍Limitation:﹍

﹍Test Link﹍:

https://dashboard.captureapp.xyz/version-9k1r/

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

  1. [issue] Correct Error Messaging(already registered) during Asset uploading process (Only happened on user modified on form page.) -> live version will have the same issue, QA will dig further, it won’t block this milestone.

﹍Testing Plan (add this after QA test):﹍

https://docs.google.com/spreadsheets/d/1ppzwv4Xf1Xm97r5abX5Egim_WAahvE7n853dibzGC9Q/edit#gid=579355519

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung

Copy link
Author

sync-by-unito bot commented Dec 5, 2023

➤ Kenny Hung commented:

Ethan Wu (cc Sherry ChungTammy Yang)

Considering that in this sprint you also need to implement staking site, about dashboard part, please deal with headline first, if other dashboard tasks need adjustment, please let us know.

Copy link
Author

sync-by-unito bot commented Dec 5, 2023

➤ Tammy Yang commented:

Kenny Hung just wondering, I thought we have already supported this? I saw it in the latest release already.

Copy link
Author

sync-by-unito bot commented Dec 5, 2023

➤ Kenny Hung commented:

Tammy Yang Dashboard headline support not only confirm page but also editing the Page(user could edit headline after asset registration.

Copy link
Author

sync-by-unito bot commented Dec 5, 2023

➤ Tammy Yang commented:

Wait, but if user edit after the registration, user needs to pay extra fee, right? I think this also needs to be considered.

Better to implement together.

Copy link
Author

sync-by-unito bot commented Dec 5, 2023

➤ Sherry Chung commented:

Ya, great point. I'll consume NUM (credits). Better to do it together. We can discuss later when Ethan is on this tasks

Copy link
Author

sync-by-unito bot commented Dec 6, 2023

➤ Kenny Hung commented:

Yes, I've summarized the miro ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764569132974689&cot=14 ) flow. Maybe we need to add a reminder to let users know these actions(edit headline & caption) need to pay a few fee for the record on-chain.

Copy link
Author

sync-by-unito bot commented Dec 6, 2023

➤ Ethan Wu commented:

we should allow users to edit headline and captions post registration.

currently when users edit captions we are just editing it with storage backend - edit media api call. not sure when this action is called if a new commit is automatically created.

if not than we will still need to edit the workflow add a commit to have the caption changed.

if users have to pay than we can add a reminder telling users that it will cost funds to make the edits.

Copy link
Author

sync-by-unito bot commented Dec 6, 2023

➤ Kenny Hung commented:

Current status: User edit captions will also create a new commit.

Copy link
Author

sync-by-unito bot commented Dec 6, 2023

➤ Ethan Wu commented:

ok than we will just need to have some UI to inform users that it will cost them some funds to make the edits

Copy link
Author

sync-by-unito bot commented Dec 12, 2023

➤ Kenny Hung commented:

Ethan Wu

Yes, For this part I found figma has already had. (cc Tammy YangSherry Chung)

image.png

@sync-by-unito sync-by-unito bot closed this as completed Dec 15, 2023
Copy link
Author

sync-by-unito bot commented Dec 15, 2023

➤ Kenny Hung commented:

Ethan Wu

  1. When user multiple uploads the file, these asset doesn’t have integrityCid. Sample as below
    1. bafkreigfzadjf6h7frqh6i2ddh7azlhrhixj3nprxo2lgwvbxxyukgwm5u

  2. The decimal point in the ‘update on-chain record’ dialog is too long.

  3. If the caption is empty, it’s not possible to modify the headline alone.

  4. If the headline or caption is modified and then cancelled, clicking ‘edit’ immediately again shows the uncorrected information. A reload is needed to display the original values.

image.png

Copy link
Author

sync-by-unito bot commented Dec 15, 2023

➤ Ethan Wu commented:

Does this only happen with all files in multiupload?

Copy link
Author

sync-by-unito bot commented Dec 15, 2023

➤ Kenny Hung commented:

Ethan Wu You mean #1? If yes, yes only happened on multiple upload.

Copy link
Author

sync-by-unito bot commented Dec 21, 2023

➤ Kenny Hung commented:

Ethan WuTammy Yang

v231214 still have some issue, please fix them.

#2, 3 Fixed

#1 Fixed, but QA found the verified will change to fail.

curl --location 'https://dia-backend.numbersprotocol.io/api/v3/assets/bafybeigf6njeutqqht7lnrdoscmqenv3fvs6a3uupobcns7gtajo7snvfa/verify-signature/?address=0x82bc4A604BABE7014F41323Fc2866550e24D9F58 ( https://dia-backend.numbersprotocol.io/api/v3/assets/bafybeigf6njeutqqht7lnrdoscmqenv3fvs6a3uupobcns7gtajo7snvfa/verify-signature/?address=0x82bc4A604BABE7014F41323Fc2866550e24D9F58 )' \

--header 'Accept: application/json' \

--header 'Authorization: token {auth_token}'

API response

{

"error": {

"type": "signature_verification_failed",

"message": "The address recovered from the signature and message is different with the provided address.",

"details": {

"provided_address": "0x82bc4A604BABE7014F41323Fc2866550e24D9F58"

}

},

"status_code": 400

}

#4 Still the same, I've created a sub-task for it. If the headline or caption is modified and then cancelled, clicking ‘edit’ immediately again shows the uncorrected information. A reload is needed to display the original values. ( https://app.asana.com/0/0/1206218031114721/f )

  1. When user change caption / headline to empty, then press confirm, actually nothing happened. ( https://app.asana.com/0/0/1206218374042983/f )

  2. [issue] Ensuring Captions are Saved and Displayed after Multiple Uploads form modification ( https://app.asana.com/0/1201083422707776/1206218374042984/f )

@sync-by-unito sync-by-unito bot reopened this Dec 21, 2023
@sync-by-unito sync-by-unito bot closed this as completed Dec 22, 2023
Copy link
Author

sync-by-unito bot commented Dec 25, 2023

➤ Kenny Hung commented:

Ethan Wu

Please fixed #1, current way could be let user can’t clean the caption, please refer Comment by @tammy Yang on When user change caption / headline to empty, then press confirm, actually nothing happened. ( https://app.asana.com/0/0/1206218374042983/1206142917957871/f )

If caption / headline has value doesn't let user clean it.

Copy link
Author

sync-by-unito bot commented Dec 25, 2023

➤ Ethan Wu commented:

Kenny Hung you mean fix it so that the fields cannot be empty?

Copy link
Author

sync-by-unito bot commented Dec 25, 2023

➤ Kenny Hung commented:

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants