Deployed to Live/Prod Site (iframe-v230822)

[sync-by-unito]

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

[sync-by-unito]

➤ Ethan Wu commented:

v230822 branch was cloned from Main branch (pre v230711 merge) and contains only order-details fixes.

pls first merge v230711 branch to Main and do code review + changes before merging v230822 branch to main.

qa will perform another test to ensure that there are no issues.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu just to confirm

Here are steps

1. Merge v230711 branch to Main
2. Do code review on Main
3. If no issue, release Main
4. Merge v230822 to Main
5. QA to perform tests on Main

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang that is correct

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu I am a bit confused, QA told me that v230808 and v230822 are pending deployed. So, according to our discussion, v230808 is actually the v230711 branch?

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang that is correct. we combined v230711 and v230808 because they only had one item each. so we combined them into a single release

[sync-by-unito]

➤ Ethan Wu commented:

v230711 => explorer show price

v230808 => fix iOS wallet display issue

the code review miro diagram has the full details.

[sync-by-unito]

➤ Tammy Yang commented:

What I did

1. Go to Main
2. Reset Main to Live
3. Go to v230711 branch => Do nothing
4. Go back to Main
5. Merge from v230711 branch => Conflicts happen (see screenshots)
6. Choose v230711 over Live (Main) and complete the merge
7. Code review v230711 (pass)
8. Go to v230822 branch
9. Reset to the latest save point v230828 - code review sent
10. Go back to Main
11. Merge from v230822 branch => no conflicts this time.
12. Create Merge with both v230711 and v230822 savepoint in Main
13. Re-release to QA

[sync-by-unito]

➤ Tammy Yang commented:

Conflicts found in step #5 (changes in v230711 were kept)

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu there is an issue in the Main branch so that I can't deploy. Please

1. Fix the issue
2. Release to QA
3. Pass QA again
4. Ping me here

As the iframe deployment has been blocked for several weeks, let's work together on this as the first priority. There is no need to work on any new release unless this is resolved, please also don't merge new releases into the Main in case it increases the complexity. Thank you!

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu Just confirm, do you fix this issue?

[sync-by-unito]

➤ Ethan Wu commented:

Tammy YangKenny Hung i don't see this issue on my bubble.

[sync-by-unito]

➤ Ethan Wu commented:

this is most often a bug on bubble side. in my experience just click on the issue and it disappears

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung pls go ahead and just test again.

[sync-by-unito]

➤ Kenny Hung commented:

Ethan WuTammy Yang

Pass, please go ahead.

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung it should be Olga to review and deploy as I shared in https://app.claap.io/numbers-protocol/bubble-code-review-and-deployment-c-O35CsUM4Uy-cRO8IAVv0Xwm ( https://app.claap.io/numbers-protocol/bubble-code-review-and-deployment-c-O35CsUM4Uy-cRO8IAVv0Xwm )

[sync-by-unito]

➤ Olga commented:

Ethan Wu (cc Kenny Hung) have you made any updates to the main branch? I noticed that the latest save point is from 4 weeks ago (Merge with both v230711 and v230822). However, the main branch shows the latest update was made 1 day ago by ethan@numbersprotocol.io. Do I need to review any updates? If not, I plan to deploy next Monday (don't deploy before the holiday).

[sync-by-unito]

➤ Tammy Yang commented:

Olga if anyone opened the branch, it is shown as "updated" by Bubble, so this information is not reliable.

What I normally do is, I always reset the Main to Live or a savepoint I kept in the Main branch before merging from any branch in order to make sure the environment is clean.

[sync-by-unito]

➤ Tammy Yang commented:

Update the sprint and arrange the due properly.

[sync-by-unito]

➤ Olga commented:

Tammy YangEthan Wu The savepoint on the main branch seems to have disappeared. When I checked last week, there was a save point labeled "Merge with both v230711 and v230822," but it's no longer there. Have you made any changes to the main branch? I'm not sure how to proceed with deployment since the savepoint is missing, and there doesn't appear to be a branch related to v230822.

[sync-by-unito]

➤ Ethan Wu commented:

Olga when i released the branch to qa i made no changes from the v230711 / v230822

[sync-by-unito]

➤ Ethan Wu commented:

Olga v230822 and v230711 have already been merged into main branch.

when i re-released it to qa last week i basically made no changes because as mentioned in the above comments the merge conflict was a bug on bubble side.

Comment by @Ethan Wu on Deployed to Live/Prod Site (iframe-v230822) ( https://app.asana.com/0/0/1205230315057714/1205588369070927/f )

Comment by @Ethan Wu on Deployed to Live/Prod Site (iframe-v230822) ( https://app.asana.com/0/0/1205230315057714/1205588369070929/f )

[sync-by-unito]

➤ Ethan Wu commented:

Sam i noticed that you made a change to the main branch in iframe? normally we do not modify the main branch directly because this is what we use for code review.

what was the change you made?

maybe we need to have qa Kenny Hung do another test and pass. after that we can create a save point called qa pass and Olga can do the deployment.

[sync-by-unito]

➤ Sam commented:

Ethan Wu, yes it says it was changed by me but so far

• I open bubble project (read docs, switch tabs)
• switch to my branch v231005-capture-cam-ifram.

I hope nothing big changed. But yes we might need test & pass.

I think it's good idea to create save points with comments.

[sync-by-unito]

➤ Ethan Wu commented:

Sam ok. yes normally we create savepoints but this is an unique scenario where we didn't make any changes and the savepoint expired (due to bubble >.<)

to be safe i think Kenny Hung can you pls do a test of version-test branch again to make sure everything is ok.

after that we can create a save point called qa pass and than we'll ping Olga to do deployment.

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu Yes, I could. But I need to confirm, should I perform C or B Level testing?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung pls do B.

we need to make sure that everything is ok

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu (cc Olga)

I found it can't display CustodialWalletWithdraw order detail.

order id: cf9b53fc-0df6-47d7-a694-d5dcc34fe54f

[sync-by-unito]

➤ Olga commented:

Ethan Wu Do you have any insights into the issue? The backend API is returning normally.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung let me take a look.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung did you test custodial wallet order id before?

[sync-by-unito]

➤ Kenny Hung commented:

Yes and I remember it just can't display image, but it doesn't stay "loading"

[sync-by-unito]

➤ Ethan Wu commented:

so it should show order not found ? Kenny Hung

[sync-by-unito]

➤ Kenny Hung commented:

No, it still could display the detail, but there isn't image(Because it doesn't have actually.)

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu this is live version display

[sync-by-unito]

➤ Ethan Wu commented:

Kenny HungTry it now

[sync-by-unito]

➤ Kenny Hung commented:

Thanks, it could work.

[sync-by-unito]

➤ Kenny Hung commented:

Ethan WuOlga

QA pass.

[sync-by-unito]

➤ Ethan Wu commented:

Olga i created a save point called qa pass.

[sync-by-unito]

➤ Olga commented:

Ethan Wu Could you please provide details about the fixes included in these save points? After reviewing the fixes, I'll proceed with deploying a reset to the save point labeled "231003 - qa pass" on the live environment.

[sync-by-unito]

➤ Ethan Wu commented:

Olga i will prepare the miro diagram

[sync-by-unito]

➤ Ethan Wu commented:

Olgahttps://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764565626602786&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764565626602786&amp;cot=14 )

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764565626602786&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764565626602786&amp;cot=14 )