Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] The same is for registering assets, but the number of commits generated by the capture app and the dashboard is different #2897

Open
sync-by-unito bot opened this issue Jul 10, 2023 · 8 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 10, 2023

User story

As a user, I want the Capture Cam to include a second commit for setting the mining preference, with the default value of "notAllowed," consistent with the dashboard.

Reproduce step

  1. use app to upload file registering assets

  2. use dashboard registering assets

  3. open the both asset profile can see Bump @capacitor/cli from 2.2.1 to 2.3.0 #1 only initial registration commit , Bump protractor from 5.4.4 to 7.0.0 #2 have one initial registration commit & theother one for miningPreference commit

Discuss :

  1. Whether the same registration action should have the same commit result
  2. If it needs to be the same, should the value of capture app commit miningPreference be the same as the default value of dashboard "notallowed"

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

Tammy YangScott YanSherry Chung (cc Ethan WuSam )

This is my proposal.

  1. Asset from Capture Cam should be also added the same commit about miningPreference & its default value should be "notAllow", the same as dashboard.

I have another question, will we add the same toggle on Capture Cam?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Ethan Wu commented:

Kenny Hung sorry clarifying to see if my understanding of this card is correct

(capture app asset)

  • will have initial registration commit

(capture dashboard asset)

  • will have initial registration commit
  • may have commit with (license, aiTraining, generatedBy, etc.)

discussion

  • do we want capture app and dashboard have the same number of commits when registering?

is my understanding of this asana card correct?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

Ethan Wu Yes

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Ethan Wu commented:

Kenny Hung from a user perspective having an extra commit to account for aiTraining will result in an extra payment (NUM payment) for the commit

  1. initial registration
  2. commit

It might make more sense to default all creations to "notAllowed" and add this to the initial registration commit. If the user wants to update to allow for AITraining then they can pay additional to create the commit.

This should also be the case for Dashboard.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Tammy Yang commented:

You are right, this needs to be taken into account. However, I would argue that there are already some users need commits twice from dashboard in order to have license, miningPreference, etc, in the additional commit.

Therefore, it may make more sense to have two commits by default always.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Tammy Yang commented:

As long as we make it clear (such as the initial registration = initial registration commit + an additional commit) and will charge 0.025×2 credits, I think it's fine.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Scott Yan commented:

no need to change will close this task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

Scott YanTammy YangEthan WuSam

Final summary for discussion.

  1. Capture Cam (Capture App) should also have the second commit for miningPreference & its default value should be "notAllow", the same as dashboard.
  2. Will add the same toggle on Capture Cam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants