Code review

[sync-by-unito]

﹍[For Ionic]﹍

Process:

1. Submit Android APK to QA ( storage-prod-bubble-prod )
2. If fail => fix and repeat Bump @capacitor/cli from 2.2.1 to 2.3.0 #1
3. If pass => submit PR
4. If need to update => fix and repeat Bump @types/node from 12.12.50 to 14.0.23 #3
5. If approved => merge and perform tests Apps from Testflight and Android Beta
6. Submit review to Apple Store and Google Play

Please paste the PR in this task, assign THIS TASK to release manager, and set due as "two days after"

﹍[For Bubble]﹍

1. Please paste send the code review form with the Miro flow
2. Please assign THIS TASK to release manager, and set due as "two days after"

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Ethan Wu commented:

code review: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554391321977&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554391321977&cot=14 )

https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554391321977&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764554391321977&cot=14 )

[sync-by-unito]

➤ Ethan Wu commented:

db diagram: https://dbdiagram.io/d/6461e13cdca9fb07c41547fe ( https://dbdiagram.io/d/6461e13cdca9fb07c41547fe )

[sync-by-unito]

➤ Tammy Yang commented:

Kenny HungEthan Wu some general issues found:

1. Not using style group (challenging to update styles) - fixed
2. Not using brand colors - fixed
3. Logo image is not clear - fixed
4. NFT logo is not consistent with other brand logos (removed) - fixed
5. Some component names are difficult to be identified - fixed
6. When hover over, sidebar colors stick with each other side-by-side (no margin) - fixed
7. Some text is from "product" point of views not "user" point of views (we should assume users have no clue what are integrity records) - fixed
8. No loading indication when it is loading - need to be fixed

[sync-by-unito]

➤ Kenny Hung commented:

cc Scott Yan