Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v230516-capture-app-ionic-internal #2698

Closed
sync-by-unito bot opened this issue Apr 3, 2023 · 26 comments
Closed

v230516-capture-app-ionic-internal #2698

sync-by-unito bot opened this issue Apr 3, 2023 · 26 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 3, 2023

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title v230418-capture-app-ionic v230420-capture-app-ionic Apr 9, 2023
@sync-by-unito sync-by-unito bot changed the title v230420-capture-app-ionic v230502-capture-app-ionic Apr 14, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 14, 2023

➤ Kenny Hung commented:

Tammy YangSam (cc Scott YanSherry Chung)

According to slack discussion ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1681471975669959 ), this release push to next sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 1, 2023

➤ Tammy Yang commented:

According to the discussions, there are more tasks need to be done in the previous milestone, move this to the next sprint

@sync-by-unito sync-by-unito bot changed the title v230502-capture-app-ionic v230516-capture-app-ionic May 1, 2023
@sync-by-unito sync-by-unito bot changed the title v230516-capture-app-ionic v230516-capture-app-ionic-internal May 10, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 16, 2023

➤ Kenny Hung commented:

Sam (cc Tammy YangScott Yan)

Warm remind, QA haven't received this release. If you need to postpone or narrow the scope, please let QA/PM know in advance.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 16, 2023

➤ Sam commented:

Kenny Hungif I can finish some task by today i will let QA know otherwise we can narrow down. Will get back to this comment later today

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 16, 2023

➤ Sam commented:

Kenny Hung

[issue] Persistent Upload Failure for Photos Taken Without Network Connection ( https://app.asana.com/0/0/1204297132869604 ) can be pushed due to unable to reproduce

[Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/0/1204361832181074 )can be pushed due to backend fix first. see comment ( https://app.asana.com/0/0/1204361832181074/1204449509492130/f )

And tomorrow I can deliver to QA v230516 with the rest tasks.

Let me know what you think.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 17, 2023

➤ Kenny Hung commented:

Sam Okay, I've pushed [issue] Persistent Upload Failure for Photos Taken Without Network Connection ( https://app.asana.com/0/1201016280880500/1204297132869604 ) to next sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 17, 2023

➤ Sam commented:

Kenny Hung, release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1684304928720689 ).

Firebase v230516-capture-app-ionic-internal

From QA point of view basic test can be performed such as

  • If basic edit caption features are OK (because iframe reload fix)
  • If Basic Take photo/video features are OK (because code quality changes)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 18, 2023

➤ Kenny Hung commented:

I have sent test device to Sam, please help to fix and re-release the new firebase version.

[Issue] Record "SHORT" can’t work normally on redmi note 10s(india) ( https://app.asana.com/0/1201083422707776/1204610474247583/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Kenny Hung commented:

Tammy Yang (cc SamScott YanSherry Chung)

Could we push this release to next sprint first week or merge into v230613 release directly?

Because

  1. Sam needs more time to figure out [Issue] Record "SHORT" can’t work normally on redmi note 10s(india) ( https://app.asana.com/0/1201016280880500/1204610474247583 ) & also needs Redmi note 10s device
  2. Currently, QA is using Redmi note 10s to test v230413-ionic official release for camera crash issue. When test done, will send it to Sam.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Tammy Yang commented:

Kenny Hung no, because it has been very long, not allowed to push TWICE. Please make a proposal HOW to close this milestone in this sprint ASAP.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Sam commented:

Tammy Yang (cc: Kenny Hung).

One thing we can try is to use native video player.

  • to play recorded video
  • to generate thumbnail

Currently we use HTML

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Tammy Yang commented:

As mentioned in the weekly sync, if it ONLY happens on one Android device, it is possible to conditional pass (still need QA to confirm)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Sam commented:

As I mentioned before ( https://dt42-numbers.slack.com/archives/C43K663U0/p1685337507895659?thread_ts=1685336418.628449&cid=C43K663U0 ) same HD video can not be played inside capture app html

By chrome

If QA can do conditional pass I could spend more time to try to find root cause and I will need Redmi 10 s again for better testing.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Sam commented:

Kenny Hung, when I can get Redmi Note 10s? Not urgent but will be helpful when I will work on [Issue] Record "SHORT" can’t work normally on redmi note 10s(india) ( https://app.asana.com/0/0/1204610474247583 ) thank you. 🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 29, 2023

➤ Kenny Hung commented:

Yes, but I'm still performing ionic-v230413-ionic test. I expect it to be done by this evening or tomorrow morning.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 4, 2023

➤ Tammy Yang commented:

Kenny HungSam how was the progress of this milestone?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 5, 2023

➤ Kenny Hung commented:

Tammy YangSam (cc Scott Yan)

Because [Limitation] Record "SHORT" can’t work normally on redmi note 10s(india) ( https://app.asana.com/0/inbox/1201776223124520/1204610474247583/1204626100814101 ) is set limitation & [Issue] Only iOS - user could upload the duplicate photo ( https://app.asana.com/0/inbox/1201776223124520/1204361832181074/1204626100814101 )will be fixed by backend, this milestone will be conditional pass. I'll submit the testing report later.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 6, 2023

➤ Sam commented:

Kenny Hung, I finished [Limitation] Record "SHORT" can’t work normally on redmi note 10s(india) ( https://app.asana.com/0/0/1204610474247583 ) and doing testing on Redmi 10s, found some edge cases I will submit v230516-capture-app-ionic-internal ( https://app.asana.com/0/0/1204317408460665 ) tomorrow morning.

@sync-by-unito sync-by-unito bot closed this as completed Jun 8, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Kenny Hung commented:

Sam

There are some new issues or need to confirm

  1. When I record a “horizontal video” on “iOS”, there is a big blank space on preview page. (Only happened on iOS, and the video asset is normal.)
  2. I try testing on my own iPhone 12 Pro, it display this image, is it normal? Will it affect user to open it? (I mean when we publish to user in the future.)

image.pngimage.png

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Sam commented:

Kenny Hung i didn tested horizontal case okey i will fix it

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Sam commented:

Kenny Hung when Developer Mode Requored haapened on iOS? I think its new iphone update

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Kenny Hung commented:

Sam #2 Yes, It happened on iOS (Only happened on my iPhone 12 pro iOS 16). I'm just worried about when we released on testflight or app store, it still shows this pop-up?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Kenny Hung commented:

Sam (cc Tammy YangScott Yan)

Just confirm, you could release today or needs more time?

If you needs more time, I suggest #1 issue could be conditional pass, and the fixed could be released with v230613-ionic together. How about you?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Kenny Hung commented:

Sam For #2, this could be skip, it's because iOS 16. I try 0.79.0 on firebase also show the same pop-up.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Sam commented:

Kenny Hung i think conditional pass and re-release with v230613 is better

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2023

➤ Kenny Hung commented:

Okay, I create [Issue] When I record a “horizontal video” on “iOS”, there is a big blank space on preview page. ( https://app.asana.com/0/1201083422707776/1204791702351923/f ) for it. (cc Tammy YangScott Yan)

Please help to fix it with v230613-capture-app-ionic ( https://app.asana.com/0/0/1204495833338689 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants