Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit figma - Prod page #2228

Closed
sync-by-unito bot opened this issue Oct 28, 2022 · 14 comments
Closed

Fit figma - Prod page #2228

sync-by-unito bot opened this issue Oct 28, 2022 · 14 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 28, 2022

https://docs.google.com/presentation/d/1u6-l_xDVBcPc708B3TR13DBKAoySjfKu7Hp-PGkfni0/edit#slide=id.g1706700024b_0_91

  1. Share icon is different
  2. Img / video should have some pedding
  3. Have title (won't de done in 1107 sprint)
  4. Registered time will display creator name below (won't de done in 1107 sprint)
  5. When caption is too long will display “Show more” (this done on v221101)

User story
As a capture app user, I want the updated prod page which fit figma design, so that I could feel the brand design is consistent.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot assigned tammyyang and unassigned tammyyang Oct 28, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung if you look at the design it looks like there a background of the photo behind the photo with opacity and gradient. are we looking to add that for ourselves?

padding:

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung could we get the share icon from noir?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

caption => done

registration time => not exposed by backend. created asana card

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Kenny Hung commented:

Ethan Wu Waiting for Noir. BTW, I found the asset page's share icon is the same, maybe Sam has this one?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 10, 2022

➤ Ethan Wu commented:

Sam can you provide the share icon with me?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 10, 2022

➤ Sam commented:

Ethan Wu share icon 👆

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Ethan Wu commented:

share icon changed. Kenny Hung

@sync-by-unito sync-by-unito bot closed this as completed Nov 14, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 18, 2022

➤ Kenny Hung commented:

Title & Registered time will implement in the future sprint. Other part is okay, Conditional pass.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Need to complete #2,#3 (Title & Registered time) in the future, incomplete and re-arrange it.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

We will not implement "title" yet. I am not convinced yet the majority people will add both "title" and "caption" for their work shared on social media.
It is just too time-consuming and does not match general user behavior.
from Tammy's comment on slack ( https://dt42-numbers.slack.com/archives/CS29L7Z5H/p1669362263930299?thread_ts=1669337371.185979&cid=CS29L7Z5H )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sherry Chung commented:

Kenny Hung (cc Ethan Wu) How about we split the "Title (Subject)" & "Registered time" request into 2 different FR then close this one? Since there already some items been updated & deployed.

@sync-by-unito sync-by-unito bot changed the title Update prod page to fit Figma design Fit figma - Prod page Dec 27, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Ethan Wu commented:

Kenny Hung comments for this one:

  1. my understanding is title is still not available in Storage Backend
  2. this one is just to add registration under creator username?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Kenny Hung commented:

Yes, just add registration under creator username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant