[issue]*in explore tab, android back button can't work.

[sync-by-unito]

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

[sync-by-unito]

➤ Sam commented:

Bofu Chen, here is the PR ( #1918 )

[sync-by-unito]

➤ Sam commented:

seems ( https://stackoverflow.com/a/3255004/6133329 ) like technical limitation, can't fix as of now.

[sync-by-unito]

➤ Kenny Hung commented:

Sam (cc Tammy Yang )
Does this issue fixed on next sprint?
Because most of our users are Android, as I know, android users usually use the back button first.
Therefore I hope to fix it before we launch rebrand campaign.

[sync-by-unito]

➤ Sam commented:

Kenny Hung, as far as I understood ( https://stackoverflow.com/questions/3254985/back-and-forward-buttons-in-an-iframe/3255004#3255004 ) it's not fixable but I will do further experimenting and see if I can fix it.

[sync-by-unito]

➤ Kenny Hung commented:

Sam (cc Tammy Yang)
Just confirm, this task could be arranged in sprint 0815? If it can't be fixed on sprint 0815, please let QA/PM know. Thanks.

[sync-by-unito]

➤ Sam commented:

asked ( https://ionic.zendesk.com/hc/en-us/requests/43039 ) ionic team. Waiting for response.

[sync-by-unito]

➤ Ethan Wu commented:

as discussed we will disable "back" button in iframe and users will need to click on explorer tab to reset their search.

I have hidden the back button on the iframe.

[sync-by-unito]

➤ Kenny Hung commented:

on 0.64.2 previous step button is disappear, but android back button still can’t work on explore tab.

[sync-by-unito]

➤ Ethan Wu commented:

Are you talking about the arrow on the bottom?

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu yes.

[sync-by-unito]

➤ Ethan Wu commented:

Ok. I believe this is an Ionic issue. Based on the previous comments Sam left it doesn't seem like it can be fixed?

[sync-by-unito]

➤ Kenny Hung commented:

It seems like that currently...
Ethan WuSam (cc Tammy YangScott Yan)
If we can't fix it, also need to find a workaround to deal with it temporarily, because the current status is not friendly to normal user, when they press something in explore tab, they only can press the explore tab can back to the prod page, if user wants to look for something, it's so difficult for them.

[sync-by-unito]

➤ Sam commented:

We can track android back button press events. And once that event occurs we can do some logic like navigate iframe back. But due to CORS we can not manipulate iframe.

Ionic team mentioned that we can try to use iframe.postMessage but we need to also setup ifram accordingly I’m not sure of bubble will allow that type of configuration. Here is the ionic team suggestion https://ionic.zendesk.com/hc/en-us/requests/43039 ( https://ionic.zendesk.com/hc/en-us/requests/43039 )

[sync-by-unito]

➤ Tammy Yang commented:

As we have decided not to show back button, the priority can be lower to High instead of Critical.

[sync-by-unito]

➤ Sam commented:

Tammy Yang (cc: Ethan Wu)
I also mentioned in the slack message ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1661925801083549 ) before. Stackoverflow solution ( https://stackoverflow.com/a/25098153/6133329 ) mentioned by ionic team conversation ( https://ionic.zendesk.com/hc/en-us/requests/43039 ).

[sync-by-unito]

➤ Sam commented:

I created this subtask: bubble app postMessage experiment ( https://app.asana.com/0/0/1202960139846421/f )

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung There are four types of back key

1. Android back key (this card)
2. Ionic back key (only in My Capture page)
3. iframe back key (see ✓ allow back key in iframe pages ( https://app.asana.com/0/0/1202969852510943 ))
4. back key on checkout page (merged with Bump @types/node from 12.12.50 to 14.0.23 #3 after ✓ Implement checkout page in the iframe app ( https://app.asana.com/0/0/1202876471263319 ) is done)

Currently according to my own test, all #2, #3, #4 can work without a problem. Therefore, I believe the priority of #1 can be Medium instead of High (well... as an Android user, I believe it's quite often that back key does not function 100% as expected?). We should keep tracking this issue and fix it, but I believe we can wait until the first rebrand version is pushed to store. Let me know if QA has any additional concerns.

[sync-by-unito]

➤ Kenny Hung commented:

Tammy Yang (cc Scott Yan)Agree. I think it's better than without any back button on iframe screen.😁
BTW, meanwhile maybe could let explore tab button just switch explore tab instead of reloading whole app.
related discuss ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1661770531329829?thread_ts=1661768150.629269&cid=C0323488MEJ )

[sync-by-unito]

➤ Tammy Yang commented:

My understanding is this is not doable. Sam how do you think?

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung btw if you also agree, I will remove this from the Thursday milestone

[sync-by-unito]

➤ Sam commented:

Tammy Yang, you this ( https://app.asana.com/0/0/1202720013896988/1202977205637168/f ) is not doable? Yes the only way to go root of explore tab is reload whole app.

[sync-by-unito]

➤ Tammy Yang commented:

Yes, correct, that's what I meant.

[sync-by-unito]

➤ Sam commented:

Tammy Yang, but I think it's doable with bubble plugin ( https://bubble.io/plugin/%F0%9F%90%9D--iframe-complete-embed-1657267144487x391836917536391200 ).

[sync-by-unito]

➤ Tammy Yang commented:

Yes, I think do, too. But, let's do it a bit later since QA has allowed us to lower the priority 😆, too busy now, haha.

[sync-by-unito]

➤ Sam commented:

Need more time to work on preferably push to next sprint

[sync-by-unito]

➤ Tammy Yang commented:

Ok, I will push this task to the next sprint

[sync-by-unito]

➤ Sam commented:

This task depends on bubble app postMessage experiment ( https://app.asana.com/0/1201016280880500/1202960139846421/f ). We need to move to next sprint

[sync-by-unito]

➤ Sam commented:

Kenny Hung, can we move this task to next sprint please? Because it depends on bubble app postMessage experiment ( https://app.asana.com/0/1201016280880500/1202960139846421/f ) sub-task.

[sync-by-unito]

➤ Kenny Hung commented:

Sam ( cc Tammy Yang) I think it could be dropped & move to product backlog first, if bubble app postMessage experiment ( https://app.asana.com/0/1201016280880500/1202960139846421 ) complete we could let it back to future sprint.

[sync-by-unito]

➤ Sam commented:

Kenny Hung (cc: Tammy Yang), explore tab android back button is fixed. Here is the claap ( https://app.claap.io/numbers-protocol/ionic-iframe-devs-android-back-button-working-for-iframe-c-O35CsUM4Uy-AfmrcRkKrMh4 ).

Implementation is done.

Kenny Hung, let me know if you want to include this task in the v221108-capture-app-ionic release note ( https://app.asana.com/0/1201016280880500/1203292734517478/f )

[sync-by-unito]

➤ Kenny Hung commented:

Sam it looks nice! And I have left comment on claap.

[sync-by-unito]

➤ Kenny Hung commented:

Tammy Yang shall we add this one to 1107 sprint?

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung sounds good!

[sync-by-unito]

➤ Kenny Hung commented:

Sam Is this one able to add v221108 release in time? If not, it's okay, also could add this one in next Tuesday release.

[sync-by-unito]

➤ Sam commented:

Code review for current PRs are not done so maybe better to add for next Tuesday. But implementation is done

[sync-by-unito]

➤ Kenny Hung commented:

okay, I arrange it in v221115 release. Warm remind, please help to updated the dev status, thanks.

[sync-by-unito]

➤ Sam commented:

Here is the PR ( #2298 )