Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-App referral program #1536

Closed
sync-by-unito bot opened this issue Apr 21, 2022 · 17 comments
Closed

In-App referral program #1536

sync-by-unito bot opened this issue Apr 21, 2022 · 17 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 21, 2022

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 28, 2022

➤ Tammy Yang commented:

Please ignore the daily tasks part for this sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 3, 2022

➤ Sam commented:

Tammy Yang where I can get the design file for invitation page? Was that implemented? We discussed details in last sprint planning but I forgot 🤦‍♂️ the detail. Would be nice to have short description of what is expected from me to be done😅🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 3, 2022

➤ Tammy Yang commented:

DaYuan please provide

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 4, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 6, 2022

➤ James Chien commented:

Sam
About backend API, please use dev-site for development first

The current user's referral code can be retrieved by this API call, the referral_code field in response
https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_me_read ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_me_read )

When registration using Sign Up API (https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create )), add a request body field referral_code if user enters the referral_code (do not add this field if user did not enter referral_code, because if the field is present inputting invalid referral code will return 400 error)

Let me know if there's anything else you need or if there's anything unclear

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 9, 2022

➤ Sam commented:

James Chien
So we have 2 places to enter referral code right?

  1. From sign up page
  2. From invitation page ( https://asana-user-private-us-east-1.s3.amazonaws.com/assets/1200886955782960/1202194404559067/a8341de43edea6e380ee57542de8c70f?X-Amz-Security-Token=IQoJb3JpZ2luX2VjECAaCXVzLWVhc3QtMSJIMEYCIQCseFQt4KqoeHVlwScXxv%2BZL3QQrhHbzJ6HWTeJ4QF1TwIhAKnQeShC01cB%2Fb2%2FeX0rqwEkU3r7O7rG3kylAdsNBQpKKtsECOn%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEQABoMNDAzNDgzNDQ2ODQwIgybLMisAwshrFPsWGQqrwRs5RSJfvqxDHy57k0I947DtGxpEsMkWn5Tm2h%2FGQ3ZWyz%2F5ERIbuxV6aCIrr%2BelhStsHRUskkpHTonTwZTFNbSvhZ%2BcFPg19gGUJ7mJWLj18vndVLwJNO6jgTv5YS5OoIhR7hMxvNdgqe0ecwQGpU6n2Uw4EcBU2f6z4abLMUusADnIT45Q5Z7X4pVm7aht%2BPktD%2FmA0778%2FWAQ%2BNQaLSoIza27cHhGWFDjUYeJXs35TGZS%2F%2BtBaLgKoqrhFRM4XxTYyoPZxIlsJeZ381ZieC0NTZFGMPvHWKMB3%2F5gqnZzQgOcnHaWGLNZYEA0TSz4GQdL4FmPWEYrFNkjK1bgUWIqFVBdZX5%2FH%2Ftx%2FCcCvO3DvTjcPLkzMKiObsSp2m%2F4B2GrWtvffss%2FcXIF7qg7uDM%2BTxKZ%2BphTkv%2BOv2f7ghvxoWCJSln8tgWfYJcWlSn%2FMescjYnYTzFSZZqR3uqyhb%2BMh0ysY7FElItJhErSd6wo4W0Ap4Tuquq9HK9JKk2khVr4Y3LU8RtJ7RLiQCeF%2B%2FwcQ7lMp06q%2F%2BljTesLnfACAgzzMtVd20%2Br2pSm5AZu%2BiNC38fXmFkRX6mn4U2kudjRDhxwsEYnkaJeSQ8Osc4oofPyniSxvRvrWyas8UU5Oxxj4pgV6QfBHZx4JI%2Fx5XAH10YePnc2N2fJo3XMkZOL6N8ifCXW9YBs4YXpPyaHuDBFkoUPXhVDVf3tdXN%2BKWybqivQM%2BHZ6X4IiJp4ykvMLuH45MGOqgB29tSrwBwRTJ%2FTkg71UV%2FnMmRAeGLJInn8t7gZ%2F6EJmNPL7VpfrRTesrCNuNIgk1PLPpm4X6ksyw1jEw60FgiRwFcDkB8dHwcMGsSc2t46sNlq8wULwKjH9RuUgjFLITD47O0Kq4620cMNUwMqC39qMS0BSt9Xsm796wJreav9zR7GBAZZLf8jFN7jdfWhR8K6hkKZL7lN1D5JX2F%2Bdb1ZJMC5xU1fb7e&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20220509T080819Z&X-Amz-SignedHeaders=host&X-Amz-Expires=120&X-Amz-Credential=ASIAV34L4ZY4DQGSCJH5%2F20220509%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=26d0de4ac8e814f39548ad5cd661e119d9712f72cff2cf7befde738da0291ea8#_=_ )

1st case: When user enter referral code from sign up page I will use this API endpoint (https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_create ))

2nd case: When user enter referral code from invitation page. Which API endpoint I should use?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 9, 2022

➤ James Chien commented:

Sam I did not aware of the invitation page feature before. I'll need to add an API for entering the invitation code after confirming some details.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Sam commented:

James Chien what if user enters referral code that can pass form validation but does not exist in the backend?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ James Chien commented:

Sam When submitting the form (sending the request) you'll get a 400 error from backend and the response will have an error_type field which you can use to identify what kind of backend error it is. An invalid referral code (not exist in backend) error will have invalid_referral_code as error_type

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ James Chien commented:

And just use the error toast to let user know that the referral code is invalid

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Sam commented:

Sofia Yan I used google translate and not sure if these are correct

Referral Code (Optional) = 推薦代碼(可選)
Invalid Referral Code = 無效的推薦代碼
Invitation = 邀請

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Sam commented:

James Chien here is the pull request Feature in app referral program ( #1594 )
I will change translations and other text after I get from Sofia

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Sam commented:

Tammy Yang for now I put simple text for share button. Let me know if text should be changed

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Sam commented:

Tammy Yang can I remove this fb, line, email icons? There is no ready plugin that allows share in fb directly or something. It can be implemented by creating another plugin or adding another plugin to support share view fb, line or email might take more time.

Currently when user clicks share button it shows native UI that can share in any apps that users installed in their app. Like in FullSizeRender.MOV demo video

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Tammy Yang commented:

Yes, please

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 10, 2022

➤ Tammy Yang commented:

Also, I think the color of the button is not consistent with other buttons in the App. Please feel free to change it.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 13, 2022

➤ Tammy Yang commented:

Sam since this has conditionally passef QA, I think you can complete it.

@sync-by-unito sync-by-unito bot closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants