Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag to resize the extension's pane? #40

Open
grantbowering opened this issue Apr 24, 2020 · 2 comments
Open

Drag to resize the extension's pane? #40

grantbowering opened this issue Apr 24, 2020 · 2 comments

Comments

@grantbowering
Copy link

Sometimes you want the video to be much larger, especially when there's only two people on the call.
I tried to implement a proof-of-concept for a drag slider last week, but my quick first crack didn't work all that well, because
a) the ember is in an <iframe> outside the body, so one can't render a slider from there that occludes the <body> content at all, and
b) I'd have to register mouse events on the body, too, because with mouse events only on an element that's in a separate iframe, it's very difficult to stay within the couple of pixels in which one could slowly drag it larger 😆
c) my approach didn't take into account, and therefore rendered useless, vemos's show-hide toggle which just shifts the fixed div over by the hard-coded 10vh, heh

I think this would be a really good feature though, so I'm adding it as a feature request.
I would poke at it some more, as I could hack around issues a) and b) above, but I don't really have any good thoughts for quickly and reasonably overcoming c), so I don't know how much help I can be.
I will PR a cleaned-up version of last week's proof of concept in a sec.

@nolaneo
Copy link
Owner

nolaneo commented Apr 24, 2020

Thanks (again!) @grantbowering. Out of interest, have you used the show/hide toggle? #7
As an alternative to a slider, I wonder could some sort of small/medium/large toggle work here too? It'd mean that from a design point of view there would be fewer cases to handle than a slider allowing arbitrary widths.

@grantbowering
Copy link
Author

Oh sorry; when I said "sometimes you want the video to be much larger", that gave the opposite impression of what I actually meant! I meant the webcam video larger, not the main video. So like, the opposite direction of the show-hide toggle. 🙂

While I do think people might appreciate being able to scale the video to exactly the pixels they want, you make a good point that a slider would be making things more difficult than they need to be. A small/medium/large toggle would be a decent MVP (and much easier to implement)... as long as the current size was the "small", and the other two sizes were much larger! 😆 Maybe 10vw, 20vw, 30vw? (I think at 30vw you can still fit two webcam videos, the buttons and the version number, if you just hide the instructions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants