From 67f2d68e165391364baec288e03c3c1440e890dd Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 15 Sep 2016 22:50:28 -0700 Subject: [PATCH 1/2] doc: update exercise portion of onboarding doc --- doc/onboarding.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index f554d5f01024bd..8c6204cfa3bfb6 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -188,14 +188,15 @@ Landing a PR * Close the pull request with a "Landed in ``" comment. -## exercise: make PRs adding yourselves to the README +## Exercise: Make a PR adding yourself to the README * Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 - * to see full URL: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` - * Collaborators in alphabetical order by username - * Label your pull request with the `doc` subsystem label - * If you would like to run CI on your PR, feel free to - * Make sure to added the `PR-URL: `! + * For raw commit message: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1` + * Collaborators are in alphabetical order by GitHub username. + * Label your pull request with the `doc` subsystem label. + * Run CI on your PR. + * After a `LGTM` or two, land the PR. + * Be sure to add the `PR-URL: ` and appropriate `Revewed-By:` metadata! ## final notes From c30748866acf2890c449a6815a01b504514bba51 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 16 Sep 2016 09:11:32 -0700 Subject: [PATCH 2/2] squash: typo fix --- doc/onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/onboarding.md b/doc/onboarding.md index 8c6204cfa3bfb6..3b0af6b4748c7d 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -196,7 +196,7 @@ Landing a PR * Label your pull request with the `doc` subsystem label. * Run CI on your PR. * After a `LGTM` or two, land the PR. - * Be sure to add the `PR-URL: ` and appropriate `Revewed-By:` metadata! + * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata! ## final notes