From bd4a5155a39956b6c232b38bb9c915b9381d6be0 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 9 Nov 2017 14:27:12 +0000 Subject: [PATCH 1/2] tools: remove unused trailing function arguments Update tools/doc/html.js and tools/eslint-rules/crypto-check.js to remove unused trailing function arguments in preparation for enabling a lint rule to enforce that practice. --- tools/doc/html.js | 2 +- tools/eslint-rules/crypto-check.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/doc/html.js b/tools/doc/html.js index 5534dd03b7441a..e25192599593f3 100644 --- a/tools/doc/html.js +++ b/tools/doc/html.js @@ -224,7 +224,7 @@ function altDocs(filename) { const host = 'https://nodejs.org'; const href = (v) => `${host}/docs/latest-v${v.num}/api/${filename}.html`; - function li(v, i) { + function li(v) { let html = `
  • ${v.num}`; if (v.lts) diff --git a/tools/eslint-rules/crypto-check.js b/tools/eslint-rules/crypto-check.js index b1b2a03f50e3b6..9d24d3355dce7f 100644 --- a/tools/eslint-rules/crypto-check.js +++ b/tools/eslint-rules/crypto-check.js @@ -54,7 +54,7 @@ module.exports = function(context) { } } - function reportIfMissingCheck(node) { + function reportIfMissingCheck() { if (hasSkipCall) { return; } From 6df6eadfe8e46d6332533865dd0ceeb58f784ec7 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 9 Nov 2017 14:28:25 +0000 Subject: [PATCH 2/2] tools: enforce no unused trailing arguments tools directory Use linting to enforce that the final argument for a function must be used. --- tools/.eslintrc.yaml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 tools/.eslintrc.yaml diff --git a/tools/.eslintrc.yaml b/tools/.eslintrc.yaml new file mode 100644 index 00000000000000..f8b7cc4e41a747 --- /dev/null +++ b/tools/.eslintrc.yaml @@ -0,0 +1,4 @@ +rules: + # Variables + # http://eslint.org/docs/rules/#variables + no-unused-vars: [error, { args: 'after-used' }]