From f2c90d065f51b6582ebe97e81f4510c1e9da1f62 Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Wed, 3 Oct 2018 13:39:14 -0700 Subject: [PATCH] tools: fix ICU shrinker and docs - tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: https://github.com/nodejs/node/issues/23245 PR-URL: https://github.com/nodejs/node/pull/23266 Reviewed-By: Refael Ackermann --- tools/icu/README.md | 4 ++-- tools/icu/shrink-icu-src.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/icu/README.md b/tools/icu/README.md index 223990bc4549c2..01c12279311441 100644 --- a/tools/icu/README.md +++ b/tools/icu/README.md @@ -92,7 +92,7 @@ make clean tools/license-builder.sh ``` -- Now, fix the default URL for the `full-icu` build in `/configure`, in +- Now, fix the default URL for the `full-icu` build in `/configure.py`, in the `configure_intl()` function. It should match the ICU URL used in the first step. When this is done, the following should build with full ICU. @@ -104,7 +104,7 @@ make make test-ci ``` -- commit the change to `configure` along with the updated `LICENSE` file. +- commit the change to `configure.py` along with the updated `LICENSE` file. - Note: To simplify review, I often will “pre-land” this patch, meaning that I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch diff --git a/tools/icu/shrink-icu-src.py b/tools/icu/shrink-icu-src.py index 63080603ad16e6..e18243542408a5 100644 --- a/tools/icu/shrink-icu-src.py +++ b/tools/icu/shrink-icu-src.py @@ -22,7 +22,7 @@ parser.add_option('--icutmp', action='store', dest='icutmp', - default='out/Release/gen/icutmp', + default='out/Release/obj/gen/icutmp', help='path to icutmp dir.')