diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc index 23b77f6aa5609f..386b4c3af07a2d 100644 --- a/src/inspector_socket.cc +++ b/src/inspector_socket.cc @@ -328,7 +328,7 @@ class WsHandler : public ProtocolHandler { } while (processed > 0 && !data->empty()); } - void Write(const std::vector data) { + void Write(const std::vector data) override { std::vector output = encode_frame_hybi17(data); WriteRaw(output, WriteRequest::Cleanup); } @@ -446,7 +446,7 @@ class HttpHandler : public ProtocolHandler { } } - void CancelHandshake() { + void CancelHandshake() override { const char HANDSHAKE_FAILED_RESPONSE[] = "HTTP/1.0 400 Bad Request\r\n" "Content-Type: text/html; charset=UTF-8\r\n\r\n" diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index bf114251cb134b..03e5c60e65641e 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -84,11 +84,6 @@ const char* MatchPathSegment(const char* path, const char* expected) { return nullptr; } -void OnBufferAlloc(uv_handle_t* handle, size_t len, uv_buf_t* buf) { - buf->base = new char[len]; - buf->len = len; -} - void PrintDebuggerReadyMessage(const std::string& host, int port, const std::vector& ids, @@ -235,7 +230,6 @@ class SocketSession { private: const int id_; InspectorSocket::Pointer ws_socket_; - InspectorSocketServer* server_; const int server_port_; std::string ws_key_; }; @@ -531,10 +525,7 @@ void InspectorSocketServer::Send(int session_id, const std::string& message) { // InspectorSession tracking SocketSession::SocketSession(InspectorSocketServer* server, int id, int server_port) - : id_(id), - server_(server), - server_port_(server_port) { } - + : id_(id), server_port_(server_port) {} void SocketSession::Send(const std::string& message) { ws_socket_->Write(message.data(), message.length());