From d8018bc91daae66f624357f995b5d44d0b899493 Mon Sep 17 00:00:00 2001 From: Mithun Sasidharan Date: Sun, 3 Dec 2017 22:45:58 +0530 Subject: [PATCH] test: update test-http-request-dont-override-options to use common.mustCall PR-URL: https://github.com/nodejs/node/pull/17438 Reviewed-By: Anatoli Papirovski Reviewed-By: Jon Moss Reviewed-By: Luigi Pinca --- .../test-http-request-dont-override-options.js | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/test/parallel/test-http-request-dont-override-options.js b/test/parallel/test-http-request-dont-override-options.js index 33ed2ed6c0070d..ff534436cb8f93 100644 --- a/test/parallel/test-http-request-dont-override-options.js +++ b/test/parallel/test-http-request-dont-override-options.js @@ -4,14 +4,13 @@ const common = require('../common'); const assert = require('assert'); const http = require('http'); -let requests = 0; -http.createServer(function(req, res) { +const server = http.createServer(common.mustCall(function(req, res) { res.writeHead(200); res.end('ok'); +})); - requests++; -}).listen(0, function() { +server.listen(0, function() { const agent = new http.Agent(); agent.defaultPort = this.address().port; @@ -30,16 +29,12 @@ http.createServer(function(req, res) { http.request(options, function(res) { res.resume(); - }).end(); - - process.on('exit', function() { - assert.strictEqual(requests, 1); - + server.close(); assert.strictEqual(options.host, undefined); assert.strictEqual(options.hostname, common.localhostIPv4); assert.strictEqual(options.port, undefined); assert.strictEqual(options.defaultPort, undefined); assert.strictEqual(options.path, undefined); assert.strictEqual(options.method, undefined); - }); -}).unref(); + }).end(); +});