From d3849117466e1986d60334126269150975d8e363 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 20 Jun 2019 14:09:34 -0600 Subject: [PATCH] doc: remove "note that" from async_hooks.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/28329 Reviewed-By: Gus Caplan Reviewed-By: Trivikram Kamat Reviewed-By: Tobias Nießen Reviewed-By: Ruben Bridgewater --- doc/api/async_hooks.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/api/async_hooks.md b/doc/api/async_hooks.md index 3e28aa21a8c3c3..487f3ac9c13c5f 100644 --- a/doc/api/async_hooks.md +++ b/doc/api/async_hooks.md @@ -111,7 +111,7 @@ const asyncHook = async_hooks.createHook({ }); ``` -Note that the callbacks will be inherited via the prototype chain: +The callbacks will be inherited via the prototype chain: ```js class MyAsyncCallbacks { @@ -439,7 +439,7 @@ added: v8.6.0 Called when the `resolve` function passed to the `Promise` constructor is invoked (either directly or through other means of resolving a promise). -Note that `resolve()` does not do any observable synchronous work. +`resolve()` does not do any observable synchronous work. The `Promise` is not necessarily fulfilled or rejected at this point if the `Promise` was resolved by assuming the state of another `Promise`. @@ -497,7 +497,7 @@ const server = net.createServer((conn) => { }); ``` -Note that promise contexts may not get precise `executionAsyncIds` by default. +Promise contexts may not get precise `executionAsyncIds` by default. See the section on [promise execution tracking][]. #### async_hooks.triggerAsyncId() @@ -520,7 +520,7 @@ const server = net.createServer((conn) => { }); ``` -Note that promise contexts may not get valid `triggerAsyncId`s by default. See +Promise contexts may not get valid `triggerAsyncId`s by default. See the section on [promise execution tracking][]. ## Promise execution tracking @@ -540,7 +540,7 @@ Promise.resolve(1729).then(() => { ``` Observe that the `then()` callback claims to have executed in the context of the -outer scope even though there was an asynchronous hop involved. Also note that +outer scope even though there was an asynchronous hop involved. Also, the `triggerAsyncId` value is `0`, which means that we are missing context about the resource that caused (triggered) the `then()` callback to be executed.