From d1b7193428f6ed244e3937f718719312749b465e Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Tue, 8 Jan 2019 10:08:54 -0500 Subject: [PATCH] deps,v8: silence V8 self-deprecation warnings PR-URL: https://github.com/nodejs/node/pull/25394 Reviewed-By: Ujjwal Sharma Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Yang Guo --- common.gypi | 9 +++++---- deps/v8/gypfiles/features.gypi | 4 ++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index cb8477aaf131c3..773dd3be7786d7 100644 --- a/common.gypi +++ b/common.gypi @@ -45,12 +45,13 @@ # Old time default, now explicitly stated. 'v8_use_snapshot': 'true', + # These are more relevant for V8 internal development. # Refs: https://github.com/nodejs/node/issues/23122 # Refs: https://github.com/nodejs/node/issues/23167 - # Enable compiler warnings when using V8_DEPRECATED apis. - 'v8_deprecation_warnings': 1, - # Enable compiler warnings when using V8_DEPRECATE_SOON apis. - 'v8_imminent_deprecation_warnings': 1, + # Enable compiler warnings when using V8_DEPRECATED apis from V8 code. + 'v8_deprecation_warnings': 0, + # Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code. + 'v8_imminent_deprecation_warnings': 0, # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, diff --git a/deps/v8/gypfiles/features.gypi b/deps/v8/gypfiles/features.gypi index 855a7a5d2f44c5..7e5af8883a8ffd 100644 --- a/deps/v8/gypfiles/features.gypi +++ b/deps/v8/gypfiles/features.gypi @@ -164,9 +164,13 @@ }], ['v8_deprecation_warnings==1', { 'defines': ['V8_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_DEPRECATION_WARNINGS',], }], ['v8_imminent_deprecation_warnings==1', { 'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',], + },{ + 'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',], }], ['v8_enable_i18n_support==1', { 'defines': ['V8_INTL_SUPPORT',],