From c52ab41d1dd96f176198df583fbc0aec285e704e Mon Sep 17 00:00:00 2001
From: ZauberNerd <zaubernerd@zaubernerd.de>
Date: Tue, 6 Nov 2018 16:40:53 +0100
Subject: [PATCH] test: add whatwg-encoding TextDecoder custom inspection with
 showHidden

These tests ensure hidden fields are shown when inspecting with
`showHidden` and that passing negative `depth` prints simplified value.

Co-authored-by: Robin Drexler <drexler.robin@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/24166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 .../test-whatwg-encoding-textdecoder.js       | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/test/parallel/test-whatwg-encoding-textdecoder.js b/test/parallel/test-whatwg-encoding-textdecoder.js
index 6d1db2ec33faad..0a812504f6179e 100644
--- a/test/parallel/test-whatwg-encoding-textdecoder.js
+++ b/test/parallel/test-whatwg-encoding-textdecoder.js
@@ -5,6 +5,7 @@ const common = require('../common');
 
 const assert = require('assert');
 const { customInspectSymbol: inspect } = require('internal/util');
+const util = require('util');
 
 const buf = Buffer.from([0xef, 0xbb, 0xbf, 0x74, 0x65,
                          0x73, 0x74, 0xe2, 0x82, 0xac]);
@@ -97,6 +98,42 @@ if (common.hasIntl) {
   assert.strictEqual(res, 'test€');
 }
 
+// Test TextDecoder inspect with hidden fields
+{
+  const dec = new TextDecoder('utf-8', { ignoreBOM: true });
+  if (common.hasIntl) {
+    assert.strictEqual(
+      util.inspect(dec, { showHidden: true }),
+      'TextDecoder {\n  encoding: \'utf-8\',\n  fatal: false,\n  ' +
+      'ignoreBOM: true,\n  [Symbol(flags)]: 4,\n  [Symbol(handle)]: {} }'
+    );
+  } else {
+    assert.strictEqual(
+      util.inspect(dec, { showHidden: true }),
+      'TextDecoder {\n  encoding: \'utf-8\',\n  fatal: false,\n  ' +
+      'ignoreBOM: true,\n  [Symbol(flags)]: 4,\n  [Symbol(handle)]:\n   ' +
+      'StringDecoder {\n     encoding: \'utf8\',\n     ' +
+      '[Symbol(kNativeDecoder)]: <Buffer 00 00 00 00 00 00 01> } }'
+    );
+  }
+}
+
+
+// Test TextDecoder inspect without hidden fields
+{
+  const dec = new TextDecoder('utf-8', { ignoreBOM: true });
+  assert.strictEqual(
+    util.inspect(dec, { showHidden: false }),
+    'TextDecoder { encoding: \'utf-8\', fatal: false, ignoreBOM: true }'
+  );
+}
+
+// Test TextDecoder inspect with negative depth
+{
+  const dec = new TextDecoder();
+  assert.strictEqual(util.inspect(dec, { depth: -1 }), '[Object]');
+}
+
 {
   const inspectFn = TextDecoder.prototype[inspect];
   const decodeFn = TextDecoder.prototype.decode;