diff --git a/lib/net.js b/lib/net.js index ce60d2f3521317..e4f97ab80debd5 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1132,9 +1132,8 @@ function Server(options, connectionListener) { return this._connections; }, 'Server.connections property is deprecated. ' + 'Use Server.getConnections method instead.'), - set: internalUtil.deprecate((val) => { - return (this._connections = val); - }, 'Server.connections property is deprecated.'), + set: internalUtil.deprecate((val) => (this._connections = val), + 'Server.connections property is deprecated.'), configurable: true, enumerable: false }); diff --git a/test/parallel/test-net-server-connections-child-null.js b/test/parallel/test-net-server-connections-child-null.js new file mode 100644 index 00000000000000..a8a1346fec3370 --- /dev/null +++ b/test/parallel/test-net-server-connections-child-null.js @@ -0,0 +1,44 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const fork = require('child_process').fork; +const net = require('net'); + +if (process.argv[2] === 'child') { + + process.on('message', (msg, socket) => { + socket.end('goodbye'); + }); + + process.send('hello'); + +} else { + + const child = fork(process.argv[1], ['child']); + + const runTest = common.mustCall(() => { + + const server = net.createServer(); + + // server.connections should start as 0 + assert.strictEqual(server.connections, 0); + server.on('connection', (socket) => { + child.send({what: 'socket'}, socket); + }); + server.on('close', () => { + child.kill(); + }); + + server.listen(0, common.mustCall(() => { + const connect = net.connect(server.address().port); + + connect.on('close', common.mustCall(() => { + // now server.connections should be null + assert.strictEqual(server.connections, null); + server.close(); + })); + })); + }); + + child.on('message', runTest); +} diff --git a/test/parallel/test-net-server-connections.js b/test/parallel/test-net-server-connections.js index 7ee1df1a544b95..01e535803a8f39 100644 --- a/test/parallel/test-net-server-connections.js +++ b/test/parallel/test-net-server-connections.js @@ -1,12 +1,18 @@ 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const net = require('net'); -// test that server.connections property is no longer enumerable now that it -// has been marked as deprecated - const server = new net.Server(); +const expectedWarning = 'Server.connections property is deprecated. ' + + 'Use Server.getConnections method instead.'; + +common.expectWarning('DeprecationWarning', expectedWarning); + +// test that server.connections property is no longer enumerable now that it +// has been marked as deprecated assert.strictEqual(Object.keys(server).indexOf('connections'), -1); + +assert.strictEqual(server.connections, 0);