From a96cc317107dd5ab70814fdb3a71e44b2bedad92 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 25 Aug 2015 09:45:42 -0700 Subject: [PATCH] test: speed up test-child-process-spawnsync.js There's a bunch of stuff in test-child-process-spawnsync.js that seems designed to test that it is in fact blocking/synchronous. However, that code really just tests the OS sleep command. Change `sleep 1` to `sleep 0` and shave about one second off the test run.` We check the return status to confirm the command is successful. The tests in this file in general would not work if spawnSync() were asynchronous. That includes this one, as a return status would not be available if the command where asynchronous. PR-URL: https://github.com/nodejs/node/pull/2542 Reviewed-By: Colin Ihrig --- test/parallel/test-child-process-spawnsync.js | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/test/parallel/test-child-process-spawnsync.js b/test/parallel/test-child-process-spawnsync.js index d66c51c9c41b2f..5cb4ec20db3588 100644 --- a/test/parallel/test-child-process-spawnsync.js +++ b/test/parallel/test-child-process-spawnsync.js @@ -4,21 +4,10 @@ var assert = require('assert'); var spawnSync = require('child_process').spawnSync; -var TIMER = 100; -var SLEEP = 1000; - -setTimeout(function() { - assert.ok(stop, 'timer should not fire before process exits'); -}, TIMER); - -console.log('sleep started'); -var start = process.hrtime(); -var ret = spawnSync('sleep', ['1']); -var stop = process.hrtime(start); +// Echo does different things on Windows and Unix, but in both cases, it does +// more-or-less nothing if there are no parameters +var ret = spawnSync('sleep', ['0']); assert.strictEqual(ret.status, 0, 'exit status should be zero'); -console.log('sleep exited', stop); -assert.strictEqual(stop[0], 1, - 'sleep should not take longer or less than 1 second'); // Error test when command does not exist var ret_err = spawnSync('command_does_not_exist', ['bar']).error;