From 97a92c4973d8144c959db6e6553fd8652ce4f1bf Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Mon, 5 Mar 2018 12:51:56 -0800 Subject: [PATCH] deps: turn in std::string for ICU - node and v8 did not call into std::string previously, so that access was shut off. - this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: https://github.com/nodejs/node/issues/19151 PR-URL: https://github.com/nodejs/node/pull/19624 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Daniel Bevenius Reviewed-By: Tiancheng "Timothy" Gu --- tools/icu/icu-generic.gyp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp index 8f29369255dfd7..a50f12d7940bf7 100644 --- a/tools/icu/icu-generic.gyp +++ b/tools/icu/icu-generic.gyp @@ -35,9 +35,7 @@ 'UCONFIG_NO_REGULAR_EXPRESSIONS=1', 'U_ENABLE_DYLOAD=0', 'U_STATIC_IMPLEMENTATION=1', - # Don't need std::string in API. - # Also, problematic: - 'U_HAVE_STD_STRING=0', + 'U_HAVE_STD_STRING=1', # TODO(srl295): reenable following pending # https://code.google.com/p/v8/issues/detail?id=3345 # (saves some space)