From 9426f0ec4a3a81214461221219a92a9f22a6ccba Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 21 Jun 2024 18:18:50 +0000 Subject: [PATCH] test: extend env for `test-node-output-errors` Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run. --- test/parallel/test-node-output-errors.mjs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/parallel/test-node-output-errors.mjs b/test/parallel/test-node-output-errors.mjs index 6c5fb398555c1b..62661d7558006c 100644 --- a/test/parallel/test-node-output-errors.mjs +++ b/test/parallel/test-node-output-errors.mjs @@ -6,8 +6,6 @@ import { describe, it } from 'node:test'; import { pathToFileURL } from 'node:url'; const skipForceColors = - process.config.variables.icu_gyp_path !== 'tools/icu/icu-generic.gyp' || - process.config.variables.node_shared_openssl || (common.isWindows && (Number(os.release().split('.')[0]) !== 10 || Number(os.release().split('.')[2]) < 14393)); // See https://github.com/nodejs/node/pull/33132 @@ -72,7 +70,7 @@ describe('errors output', { concurrency: !process.env.TEST_PARALLEL }, () => { { name: 'errors/promise_unhandled_warn_with_error.js', transform: promiseTransform }, { name: 'errors/unhandled_promise_trace_warnings.js', transform: promiseTransform }, { skip: skipForceColors, name: 'errors/force_colors.js', - transform: forceColorsTransform, env: { FORCE_COLOR: 1 } }, + transform: forceColorsTransform, env: { ...process.env, FORCE_COLOR: 1 } }, ]; for (const { name, transform = defaultTransform, env, skip = false } of tests) { it(name, { skip }, async () => {