From 8dc7713c2873c4d35d85cd8da4be9e3ead336321 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Tue, 6 Feb 2018 21:29:26 +0100 Subject: [PATCH] stream: fix misleading error message The method to implement is `_write` not `_transform`. PR-URL: https://github.com/nodejs/node/pull/18604 Reviewed-By: Ruben Bridgewater Reviewed-By: Anna Henningsen Reviewed-By: Anatoli Papirovski Reviewed-By: Colin Ihrig Reviewed-By: Matteo Collina --- lib/_stream_writable.js | 2 +- .../test-stream-writable-constructor-set-methods.js | 12 +++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js index 9c1b32b81dc957..f927d59491fb8c 100644 --- a/lib/_stream_writable.js +++ b/lib/_stream_writable.js @@ -551,7 +551,7 @@ function clearBuffer(stream, state) { } Writable.prototype._write = function(chunk, encoding, cb) { - cb(new errors.Error('ERR_METHOD_NOT_IMPLEMENTED', '_transform')); + cb(new errors.Error('ERR_METHOD_NOT_IMPLEMENTED', '_write')); }; Writable.prototype._writev = null; diff --git a/test/parallel/test-stream-writable-constructor-set-methods.js b/test/parallel/test-stream-writable-constructor-set-methods.js index a12112d1ecc266..441e8ee75b337d 100644 --- a/test/parallel/test-stream-writable-constructor-set-methods.js +++ b/test/parallel/test-stream-writable-constructor-set-methods.js @@ -1,5 +1,5 @@ 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const Writable = require('stream').Writable; @@ -26,6 +26,16 @@ w2.write(Buffer.from('blerg')); w2.write(Buffer.from('blerg')); w2.end(); +const w3 = new Writable(); + +w3.on('error', common.expectsError({ + type: Error, + code: 'ERR_METHOD_NOT_IMPLEMENTED', + message: 'The _write method is not implemented' +})); + +w3.end(Buffer.from('blerg')); + process.on('exit', function() { assert.strictEqual(w._write, _write); assert(_writeCalled);